FlatsMatroid: improve validity check
#39563
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 0b80558; changes) is ready! 🎉 |
tscrim
approved these changes
Jun 16, 2025
Use `len`. Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
|
Change applied. Thank you for the review! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 18, 2025
sagemathgh-39563: `FlatsMatroid`: improve validity check More robust and faster `is_valid` method. Also, more efficient initialization when an iterable of flats is given. A speed test with ~25% speedup: ``` sage: from sage.matroids.flats_matroid import FlatsMatroid sage: M = FlatsMatroid(matroids.CompleteGraphic(8)) sage: %timeit M.is_valid() ``` Includes minor refactoring in `CircuitsMatroid` class. URL: sagemath#39563 Reported by: gmou3 Reviewer(s): Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 21, 2025
sagemathgh-39563: `FlatsMatroid`: improve validity check More robust and faster `is_valid` method. Also, more efficient initialization when an iterable of flats is given. A speed test with ~25% speedup: ``` sage: from sage.matroids.flats_matroid import FlatsMatroid sage: M = FlatsMatroid(matroids.CompleteGraphic(8)) sage: %timeit M.is_valid() ``` Includes minor refactoring in `CircuitsMatroid` class. URL: sagemath#39563 Reported by: gmou3 Reviewer(s): Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More robust and faster
is_validmethod. Also, more efficient initialization when an iterable of flats is given.A speed test with ~25% speedup:
Includes minor refactoring in
CircuitsMatroidclass.