Fix basis of multivariate polynomial ring #39425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Documentation preview for this PR (built with commit a10eb6f; changes) is ready! 🎉 |
tscrim
approved these changes
Feb 3, 2025
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
|
Thank you. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 4, 2025
sagemathgh-39425: Fix basis of multivariate polynomial ring Previously `.basis()` method doesn't work there. (vector space basis) Issue popped up while working on sagemath#39089 Also fix a corner case in `IntegerVectors` iteration where `length=0`. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39425 Reported by: user202729 Reviewer(s): Travis Scrimshaw, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 9, 2025
sagemathgh-39425: Fix basis of multivariate polynomial ring Previously `.basis()` method doesn't work there. (vector space basis) Issue popped up while working on sagemath#39089 Also fix a corner case in `IntegerVectors` iteration where `length=0`. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39425 Reported by: user202729 Reviewer(s): Travis Scrimshaw, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 9, 2025
sagemathgh-39425: Fix basis of multivariate polynomial ring Previously `.basis()` method doesn't work there. (vector space basis) Issue popped up while working on sagemath#39089 Also fix a corner case in `IntegerVectors` iteration where `length=0`. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39425 Reported by: user202729 Reviewer(s): Travis Scrimshaw, user202729
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 18, 2025
sagemathgh-39089: Change __call__ to _element_constructor_ in multipolynomial ring It's not recommended to override `__call__`. Some dependent pull requests are needed to let tests pass. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have created tests covering the changes. (probably not needed) - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - sagemath#39425 to fix test failure - sagemath#39419 to fix more test failure (because the coercion system works differently when `__call__` is overloaded versus it isn't) URL: sagemath#39089 Reported by: user202729 Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jul 20, 2025
sagemathgh-39089: Change __call__ to _element_constructor_ in multipolynomial ring It's not recommended to override `__call__`. Some dependent pull requests are needed to let tests pass. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have created tests covering the changes. (probably not needed) - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - sagemath#39425 to fix test failure - sagemath#39419 to fix more test failure (because the coercion system works differently when `__call__` is overloaded versus it isn't) URL: sagemath#39089 Reported by: user202729 Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously
.basis()method doesn't work there. (vector space basis)Issue popped up while working on #39089
Also fix a corner case in
IntegerVectorsiteration wherelength=0.📝 Checklist
⌛ Dependencies