Fix bug with sage_getfile in meson editable install #39424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 2a3aee0; changes) is ready! 🎉 |
3 tasks
|
Side note, |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 9, 2025
sagemathgh-39424: Fix bug with sage_getfile in meson editable install Previously, the following test fails with meson editable install ``` 2025-01-28T04:27:13.4765580Z File "src/sage/misc/cachefunc.pyx", line 881, in sage.misc.cachefunc.CachedFunction._instancedoc_ 2025-01-28T04:27:13.4766297Z Failed example: 2025-01-28T04:27:13.4766651Z os.path.exists(sage_getfile(I.groebner_basis)) 2025-01-28T04:27:13.4767084Z Expected: 2025-01-28T04:27:13.4767330Z True 2025-01-28T04:27:13.4767571Z Got: 2025-01-28T04:27:13.4767808Z False ``` See https://github.com/sagemath/sage/actions/runs/13003203795/job/362655 39648 . ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. (can't really test, but see sagemath#39369) - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39424 Reported by: user202729 Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 9, 2025
sagemathgh-39424: Fix bug with sage_getfile in meson editable install Previously, the following test fails with meson editable install ``` 2025-01-28T04:27:13.4765580Z File "src/sage/misc/cachefunc.pyx", line 881, in sage.misc.cachefunc.CachedFunction._instancedoc_ 2025-01-28T04:27:13.4766297Z Failed example: 2025-01-28T04:27:13.4766651Z os.path.exists(sage_getfile(I.groebner_basis)) 2025-01-28T04:27:13.4767084Z Expected: 2025-01-28T04:27:13.4767330Z True 2025-01-28T04:27:13.4767571Z Got: 2025-01-28T04:27:13.4767808Z False ``` See https://github.com/sagemath/sage/actions/runs/13003203795/job/362655 39648 . ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. (can't really test, but see sagemath#39369) - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39424 Reported by: user202729 Reviewer(s): Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 9, 2025
sagemathgh-39369: Test pip editable install with meson Tests pip editable install with meson on GitHub Actions. This uncovers several failing tests, which are fixed by (see dependencies below) Note: review is hard because of the large number of dependencies. It is probably easier to look only in `.github` folder. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. ### ⌛ Dependencies - sagemath#39423 - sagemath#39498 - sagemath#39494 - sagemath#39424 - sagemath#39275 - sagemath#39499 URL: sagemath#39369 Reported by: user202729 Reviewer(s): Tobias Diez, user202729
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the following test fails with meson editable install
See https://github.com/sagemath/sage/actions/runs/13003203795/job/36265539648 .
📝 Checklist
⌛ Dependencies