remove a deprecation simplicial complexes #39462
Merged
+5
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 547b3a6; changes) is ready! 🎉 |
dcoudert
reviewed
Feb 6, 2025
| facets.append(tuple(["L" + str(v) for v in f])) | ||
| for f in right._facets: | ||
| facets.append(tuple(["R" + str(v) for v in f])) | ||
| facets = [tuple(["L" + str(v) for v in f]) |
There was a problem hiding this comment.
- I think you can directly write
tuple("L" + str(v) for v in f)to avoid building a list. - you could also use iterators and
itertools.chain
facetsL = (tuple("L" + str(v) for v in f) for f in self._facets)
facetsR = (tuple("R" + str(v) for v in f) for f in right._facets)
from itertools import chain
return SimplicialComplex(chain(facetsL, facetsR), is_mutable=is_mutable)Well, these are minor possible improvements.
There was a problem hiding this comment.
merci pour la suggestion. Je l'ai suivi à moitié. C'est pas vraiment l'objectif principal ici
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 9, 2025
sagemathgh-39462: remove a deprecation simplicial complexes found using the scripts in sagemath#39262 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39462 Reported by: Frédéric Chapoton Reviewer(s): David Coudert, Frédéric Chapoton
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 9, 2025
sagemathgh-39462: remove a deprecation simplicial complexes found using the scripts in sagemath#39262 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39462 Reported by: Frédéric Chapoton Reviewer(s): David Coudert, Frédéric Chapoton
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
found using the scripts in #39262
📝 Checklist