sagemath · vbraun · Mar 9, 2025 · Jan 22, 2025 · Jan 22, 2025 · Jan 22, 2025
diff --git a/.github/workflows/ci-meson.yml b/.github/workflows/ci-meson.yml
@@ -16,14 +16,21 @@ concurrency:
 
 jobs:
   test:
-    name: Conda (${{ matrix.os }}, Python ${{ matrix.python }})
+    name: Conda (${{ matrix.os }}, Python ${{ matrix.python }}${{ matrix.editable && ', editable' || '' }})
     runs-on: ${{ matrix.os }}-latest
 
     strategy:
       fail-fast: false
       matrix:
         os: [ubuntu]
         python: ['3.11', '3.12']
+        editable:
+          ${{ fromJson(github.event_name == 'pull_request' && '[false]' || '[false, true]') }}
+        include:
+          # one additional editable run in pull_request, this has no effect if not pull_request
+          - os: ubuntu
+            python: 3.12
+            editable: true
 
     steps:
       - uses: actions/checkout@v4
@@ -70,7 +77,7 @@ jobs:
           export CC="ccache $CC"
           export CXX="ccache $CXX"
           # Use --no-deps and pip check below to verify that all necessary dependencies are installed via conda
-          pip install --no-build-isolation --no-deps --config-settings=builddir=builddir . -v
+          pip install --no-build-isolation --no-deps --config-settings=builddir=builddir ${{ matrix.editable && '--editable' || '' }} . -v
 
       - name: Check update-meson
         # this step must be after build, because meson.build creates a number of __init__.py files
@@ -93,12 +100,14 @@ jobs:
         shell: bash -l {0}
         run: |
           # We don't install sage_setup, so don't try to test it
-          rm -R ./src/sage_setup/
+          # If editable then deleting the directory will cause sage to detect rebuild, which will cause ninja to fail
+          # so we don't delete the directory in this case
+          ${{ matrix.editable && 'true' || 'rm -R ./src/sage_setup/' }}
           ./sage -t --all -p4 --format github
 
       - name: Upload log
         uses: actions/upload-artifact@v4.5.0
         if: failure()
         with:
-          name: ${{ runner.os }}-meson-${{ matrix.python }}-log
+          name: ${{ runner.os }}-meson-${{ matrix.python }}${{ matrix.editable && '-editable' || '' }}-log
           path: builddir/meson-logs/