-
-
Notifications
You must be signed in to change notification settings - Fork 649
Addition of new presentations to Chow rings of matroids #39359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Documentation preview for this PR (built with commit 5f5d545; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost ready; just a few more small things.
@tscrim Do you just mean adding the two lines |
I had 2 things in my previous comment (which you can see in the filed changed), and I was referring to this part:
|
Right, understood. Do you mean a check for |
I meant what I said, add it as an argument to |
@25shriya Some lint issues with trailing whitespace. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. One last little thing before a positive review, and please check that it does work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. Let's get this in.
Why has the label changed? Shouldn't this be merged by now? |
The "smarter"-than-us-auto-bot decided to later revert it back because of the merge. Thanks for catching this. |
Should I ignore the build-doc failure? Looks like an error that's not a part of the code I wrote. |
It didn't run properly, so I am re-running it. |
sagemathgh-39359: Addition of new presentations to Chow rings of matroids <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> This PR focuses on adding the atom-free and simplicial presentation of Chow rings of matroids. [see relevant issue](sagemath#37987) The former is taken from Definition 4.1 of [this paper](https://arxiv.org/abs/2111.00393) and the latter from Definition 3.2.1 of [this paper](https://arxiv.org/pdf/1905.07114). @tscrim ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39359 Reported by: Shriya Meenakshisundaram Reviewer(s): Shriya Meenakshisundaram, Travis Scrimshaw
This PR focuses on adding the atom-free and simplicial presentation of Chow rings of matroids. see relevant issue
The former is taken from Definition 4.1 of this paper and the latter from Definition 3.2.1 of this paper.
@tscrim
📝 Checklist
⌛ Dependencies