Meson: find more dependencies via pkg-config #38993
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 41280d7; changes) is ready! 🎉 |
antonio-rojas
suggested changes
Dec 23, 2024
src/meson.build
Outdated
| # Test for common.h header that was added in 4.12 as a indirect version check | ||
| gap = cc.find_library('gap', has_headers: ['gap/common.h']) | ||
|
|
||
| gap = dependency('gap', version: '>=4.13.0', required: false) |
There was a problem hiding this comment.
gap's pc file is called libgap, not gap
4a01db5 to
41280d7
Compare
|
LGTM otherwise |
dimpase
approved these changes
Dec 23, 2024
|
Thanks @antonio-rojas for the suggestion, and both of you for the review! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 1, 2025
sagemathgh-38993: Meson: find more dependencies via pkg-config <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Use pkg-config to find more dependencies, and add version constraints (mostly) as specified in the `spkg-configure` scripts. Now only the packages without pkg-config info use `find_library` (refs sagemath#39064) ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies - sagemath#37447 for the updated conda lock files <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38993 Reported by: Tobias Diez Reviewer(s): Antonio Rojas, Dima Pasechnik
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use pkg-config to find more dependencies, and add version constraints (mostly) as specified in the
spkg-configurescripts.Now only the packages without pkg-config info use
find_library(refs #39064)📝 Checklist
⌛ Dependencies