Skip to content

Conversation

dimpase
Copy link
Member

@dimpase dimpase commented Oct 24, 2024

Update - we're spitting this into a number of PRs: #39652, #39653, #39654, #39655

this is a slightly rebased/squashed #38227, updated build/pkgs/numpy 2.0.1, scipy 1.13.1, cmake 3.30.2, gsl 2.8, meson 1.5.1, meson_python 0.16.0, ninja_build 1.12.1, openblas 0.3.28, pybind11 2.13.1, pythran 0.16.1

📝 Checklist

  • [ x] The title is concise and informative.
  • [ x] The description explains in detail what this PR is about.
  • [ x] I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

Documentation preview for this PR (built with commit feaa1bb; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@kiwifb
Copy link
Member

kiwifb commented Oct 24, 2024

Does the flint_wrap.h patch belong here?

@dimpase
Copy link
Member Author

dimpase commented Oct 24, 2024

I don't know. IMHO this was already in, no?

@kiwifb
Copy link
Member

kiwifb commented Oct 24, 2024

I don't know. IMHO this was already in, no?

It is not currently in develop if that's what you mean. Nor is it in the current merge branch of Volker. It certainly needs to be added somewhere. It just has nothing to do with the description of the PR - unless it is needed for it to work somehow.

@dimpase
Copy link
Member Author

dimpase commented Oct 24, 2024

ok, I'll remove it. I only recall I did a flint PR to fix this, and that it was a fight around it. please excuse my PTSD :-)

@@ -8,11 +8,12 @@ requires = [
'wheel >=0.36.2',
'cypari2 >=2.1.1',
'cysignals >=1.10.2',
# Exclude 3.0.3 because of https://github.com/cython/cython/issues/5748
'cython >=3.0, != 3.0.3, <4.0',
# per https://github.com/scipy/scipy/blob/maintenance/1.13.x/pyproject.toml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please revert these changes to pyproject.toml. This file defines the version constraints of building the sagelib project, and for this it doesn't matter what constraints scipy has for building itself.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've given you the rights to push directly to my fork. Please accept the invite and fix what's needed - I'm not 100% sure I get what you'd exactly want to change.

@dimpase
Copy link
Member Author

dimpase commented Oct 25, 2024

I don't know. IMHO this was already in, no?

It is not currently in develop if that's what you mean. Nor is it in the current merge branch of Volker. It certainly needs to be added somewhere. It just has nothing to do with the description of the PR - unless it is needed for it to work somehow.

OK, done in a060054

@dimpase dimpase changed the title updates: numpy 2.0.1, scipy 1.13.1, cmake 3.30.2, gsl 2.8, meson 1.5.1, meson_python 0.16.0, ninja_build 1.12.1, openblas 0.3.28, pybind11 2.13.1, pythran 0.16.1 #38227 updates: numpy 2.0.1, scipy 1.13.1, cmake 3.30.2, gsl 2.8, meson 1.5.1, meson_python 0.16.0, ninja_build 1.12.1, openblas 0.3.28, pybind11 2.13.1, pythran 0.16.1 (from #38227) Oct 26, 2024
@dimpase
Copy link
Member Author

dimpase commented Mar 8, 2025

instead of one blob, we'll do this in steps:

@dimpase dimpase closed this Mar 8, 2025
@dimpase dimpase changed the title updates: numpy 2.0.1, scipy 1.13.1, cmake 3.30.2, gsl 2.8, meson 1.5.1, meson_python 0.16.0, ninja_build 1.12.1, openblas 0.3.28, pybind11 2.13.1, pythran 0.16.1 (from #38227) updates: numpy 2.0.1, scipy 1.13.1, gsl 2.8, pybind11 2.13.1, ninja 1.11.1.3 - etc (already done removed) (from #38227) Mar 8, 2025
@dimpase dimpase changed the title updates: numpy 2.0.1, scipy 1.13.1, gsl 2.8, pybind11 2.13.1, ninja 1.11.1.3 - etc (already done removed) (from #38227) updates: numpy 2.0.1, scipy 1.13.1, gsl 2.8 - etc (already done removed) (from #38227) Mar 8, 2025
@dimpase dimpase changed the title updates: numpy 2.0.1, scipy 1.13.1, gsl 2.8 - etc (already done removed) (from #38227) updates: gsl 2.8 - etc (already done removed from title) (from #38227) Mar 9, 2025
@dimpase
Copy link
Member Author

dimpase commented Mar 9, 2025

dear reviewers, please review #39652, #39653, #39654, #39655

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants