-
-
Notifications
You must be signed in to change notification settings - Fork 654
updates: gsl 2.8 - etc (already done removed from title) (from #38227) #38846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Documentation preview for this PR (built with commit feaa1bb; changes) is ready! 🎉 |
Does the flint_wrap.h patch belong here? |
I don't know. IMHO this was already in, no? |
It is not currently in develop if that's what you mean. Nor is it in the current merge branch of Volker. It certainly needs to be added somewhere. It just has nothing to do with the description of the PR - unless it is needed for it to work somehow. |
ok, I'll remove it. I only recall I did a flint PR to fix this, and that it was a fight around it. please excuse my PTSD :-) |
@@ -8,11 +8,12 @@ requires = [ | |||
'wheel >=0.36.2', | |||
'cypari2 >=2.1.1', | |||
'cysignals >=1.10.2', | |||
# Exclude 3.0.3 because of https://github.com/cython/cython/issues/5748 | |||
'cython >=3.0, != 3.0.3, <4.0', | |||
# per https://github.com/scipy/scipy/blob/maintenance/1.13.x/pyproject.toml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please revert these changes to pyproject.toml
. This file defines the version constraints of building the sagelib project, and for this it doesn't matter what constraints scipy has for building itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've given you the rights to push directly to my fork. Please accept the invite and fix what's needed - I'm not 100% sure I get what you'd exactly want to change.
OK, done in a060054 |
instead of one blob, we'll do this in steps:
|
Update - we're spitting this into a number of PRs: #39652, #39653, #39654, #39655
this is a slightly rebased/squashed #38227, updated build/pkgs/numpy 2.0.1, scipy 1.13.1, cmake 3.30.2, gsl 2.8, meson 1.5.1, meson_python 0.16.0, ninja_build 1.12.1, openblas 0.3.28, pybind11 2.13.1, pythran 0.16.1
📝 Checklist
⌛ Dependencies