Skip to content

Conversation

saraedum
Copy link
Member

@saraedum saraedum commented Jul 23, 2024

This fixes two layout errors in the documentation.

Before

image

After

image

Before

image

After

image

@saraedum saraedum changed the title Updated SageMath version to 10.4 Fix layout of conda installation instructions Jul 23, 2024
Copy link

github-actions bot commented Jul 23, 2024

Documentation preview for this PR (built with commit 237c7b6; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@saraedum saraedum marked this pull request as ready for review July 23, 2024 09:31
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vbraun pushed a commit to vbraun/sage that referenced this pull request Jul 25, 2024
This fixes two layout errors in the documentation.

##### Before
![image](https://github.com/user-
attachments/assets/833a9b4b-da41-4734-9d42-f98daf6249fa)

##### After
![image](https://github.com/user-
attachments/assets/f4352c94-99be-4b93-9e5a-e9c8b0ed5c26)

##### Before
![image](https://github.com/user-
attachments/assets/07f25208-391d-4702-9ccc-c9335ea3fa97)

##### After
![image](https://github.com/user-
attachments/assets/5a33c08c-e878-49ed-8269-0f38b62e28a9)

URL: sagemath#38408
Reported by: Julian Rüth
Reviewer(s): Matthias Köppe
Copy link

@bagasme bagasme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting looks OK (unwrapping instructions in quote blocks).

vbraun pushed a commit to vbraun/sage that referenced this pull request Jul 31, 2024
sagemathgh-38408: Fix layout of conda installation instructions
    
This fixes two layout errors in the documentation.

##### Before
![image](https://github.com/user-
attachments/assets/833a9b4b-da41-4734-9d42-f98daf6249fa)

##### After
![image](https://github.com/user-
attachments/assets/f4352c94-99be-4b93-9e5a-e9c8b0ed5c26)

##### Before
![image](https://github.com/user-
attachments/assets/07f25208-391d-4702-9ccc-c9335ea3fa97)

##### After
![image](https://github.com/user-
attachments/assets/5a33c08c-e878-49ed-8269-0f38b62e28a9)
    
URL: sagemath#38408
Reported by: Julian Rüth
Reviewer(s): Bagas Sanjaya, Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Aug 2, 2024
sagemathgh-38408: Fix layout of conda installation instructions
    
This fixes two layout errors in the documentation.

##### Before
![image](https://github.com/user-
attachments/assets/833a9b4b-da41-4734-9d42-f98daf6249fa)

##### After
![image](https://github.com/user-
attachments/assets/f4352c94-99be-4b93-9e5a-e9c8b0ed5c26)

##### Before
![image](https://github.com/user-
attachments/assets/07f25208-391d-4702-9ccc-c9335ea3fa97)

##### After
![image](https://github.com/user-
attachments/assets/5a33c08c-e878-49ed-8269-0f38b62e28a9)
    
URL: sagemath#38408
Reported by: Julian Rüth
Reviewer(s): Bagas Sanjaya, Matthias Köppe
@vbraun vbraun merged commit 254ec39 into sagemath:develop Aug 3, 2024
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants