Skip to content

Conversation

fchapoton
Copy link
Contributor

as this is currently badly broken

not sure the changes are all innocuous

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

@fchapoton fchapoton changed the title fixin the ruff' linter (yeah) fixin the ruff' linter Jun 29, 2024
@fchapoton fchapoton changed the title fixin the ruff' linter fixin' the ruff linter Jun 29, 2024
@fchapoton
Copy link
Contributor Author

the fixes in src/sage/manifolds/differentiable/characteristic_cohomology_class.py are breaking the doctests there

@egourgoulhon : please have a look

Copy link

github-actions bot commented Jun 29, 2024

Documentation preview for this PR (built with commit 08f0c91; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>
@vbraun vbraun merged commit 812a116 into sagemath:develop Jul 4, 2024
@fchapoton fchapoton deleted the fix_ruff_linter_checks branch July 5, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: blocker / 1 p: CI Fix merged before running CI tests v: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants