You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As reported by @culler, when Sage is configured with ./configure --disable-editable silently fails to install the Sage library in the venv (including scripts such as sage-ipython).
./sage -pip list | grep sage will show no sagemath-standard
The build log shows these messages:
[spkg-install] Successfully built sagemath_standard-10.4rc1-cp312-cp312-macosx_14_0_x86_64.whl
[spkg-install] Staged wheel file, staged /doesnotexist/sagelib/spkg-requirements.txt
[spkg-install] /Users/mkoeppe/s/sage/sage-rebasing/worktree-pristine/build/bin/sage-dist-helpers: line 367: /doesnotexist/sagelib/spkg-pipinst: No such file or directory
[spkg-install] /Users/mkoeppe/s/sage/sage-rebasing/worktree-pristine/build/bin/sage-dist-helpers: line 387: /doesnotexist/sagelib/spkg-piprm: No such file or directory
Moving package files from temporary location /Users/mkoeppe/s/sage/sage-rebasing/worktree-pristine/venv-wheels/var/tmp/sage/build/sagelib-10.4.rc1/inst to /Users/mkoeppe/s/sage/sage-rebasing/worktree-pristine/venv-wheels
Deleting build directory /Users/mkoeppe/s/sage/sage-rebasing/worktree-pristine/venv-wheels/var/tmp/sage/build/sagelib-10.4.rc1
Finished installing sagelib-10.4.rc1
With this PR I am able to build Sage, and when I run it I get a working prompt. Also, the p_group_cohomology spkg installs correctly.
Some comments:
1.. I am still getting a failure of sage_numerical_backends_coin. That failure is unrelated. It is a Cython error caused by having several definitions of cpdef functions which omit the noexcept qualifier which appears in the declarations of those functions. I will attach a patch file that worked for me when I added it to the spkg directory.
2. I think that non-editable installs should be the default, not the other way around. Editable installs are for developers, not users.
3. The prebuilt configure file for 10.4rc1 release did not make it to the mirrors. I had to install autoconf on one of my build systems. noexcept.patch
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported by @culler, when Sage is configured with
./configure --disable-editablesilently fails to install the Sage library in the venv (including scripts such assage-ipython)../sage -pip list | grep sagewill show nosagemath-standardThe build log shows these messages:
Fixed here in this PR.
📝 Checklist
⌛ Dependencies