Skip to content

Fix a bug that breaks CHANGES.html again #38353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2024
Merged

Fix a bug that breaks CHANGES.html again #38353

merged 1 commit into from
Jul 16, 2024

Conversation

kwankyu
Copy link
Collaborator

@kwankyu kwankyu commented Jul 13, 2024 •
edited
Loading

This is my foolish mistake made in #38332. Sorry.

Trivial fix.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@kwankyu
Copy link
Collaborator Author

kwankyu commented Jul 13, 2024

@mkoeppe please.

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit d2c0e54; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

mkoeppe
mkoeppe approved these changes Jul 13, 2024
View reviewed changes
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwankyu
Copy link
Collaborator Author

kwankyu commented Jul 13, 2024

Thanks!

@vbraun vbraun merged commit 01b4ec9 into sagemath:develop Jul 16, 2024
@kwankyu kwankyu deleted the p/fix-bug-in-changes.html branch July 17, 2024 01:19
@kwankyu kwankyu mentioned this pull request Jul 17, 2024
Merged
5 tasks
@kwankyu kwankyu restored the p/fix-bug-in-changes.html branch July 17, 2024 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mkoeppe mkoeppe mkoeppe approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
p: blocker / 1 v: minimal
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
3 participants
@kwankyu @mkoeppe @vbraun