Skip to content

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jun 15, 2024

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Jun 21, 2024

Documentation preview for this PR (built with commit fda7603; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 23, 2024

@kwankyu
Copy link
Collaborator

kwankyu commented Aug 8, 2024

I get

sage -t --warn-long 69.9 --random-seed=274666681782489637879204037307995713165 src/sage/graphs/generic_graph.py
**********************************************************************
File "src/sage/graphs/generic_graph.py", line 15996, in sage.graphs.generic_graph.GenericGraph.?
Failed example:
    (graphs.FruchtGraph()).clustering_coeff(weight=True)                  # needs networkx
Expected:
    {0: 0.3333333333333333, 1: 0.3333333333333333, 2: 0,
     3: 0.3333333333333333, 4: 0.3333333333333333,
     5: 0.3333333333333333, 6: 0.3333333333333333,
     7: 0.3333333333333333, 8: 0, 9: 0.3333333333333333,
     10: 0.3333333333333333, 11: 0}
Got:
    {0: np.float64(0.3333333333333333),
     1: np.float64(0.3333333333333333),
     2: 0,
     3: np.float64(0.3333333333333333),
     4: np.float64(0.3333333333333333),
     5: np.float64(0.3333333333333333),
     6: np.float64(0.3333333333333333),
     7: np.float64(0.3333333333333333),
     8: 0,
     9: np.float64(0.3333333333333333),
     10: np.float64(0.3333333333333333),
     11: 0}
**********************************************************************
File "src/sage/graphs/generic_graph.py", line 16006, in sage.graphs.generic_graph.GenericGraph.?
Failed example:
    (graphs.FruchtGraph()).clustering_coeff(nodes=[0,1,2],                # needs networkx
                                            weight=True)
Expected:
    {0: 0.3333333333333333, 1: 0.3333333333333333, 2: 0}
Got:
    {0: np.float64(0.3333333333333333), 1: np.float64(0.3333333333333333), 2: 0}
**********************************************************************
1 item had failures:
   2 of 1269 in sage.graphs.generic_graph.GenericGraph.?
    [3915 tests, 2 failures, 23.88 s]
----------------------------------------------------------------------
sage -t --warn-long 69.9 --random-seed=274666681782489637879204037307995713165 src/sage/graphs/generic_graph.py  # 2 doctests failed
----------------------------------------------------------------------

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 18, 2024

https://github.com/mkoeppe/sage/actions/runs/10437086696/job/28902874363#step:11:5246

#29 3702.4   [sagemath_doc_html-none]   [spkg-install] [rings_num] Could not import extension matplotlib.sphinxext.plot_directive (exception: /sage/local/var/lib/sage/venv-python3.9/lib64/python3.9/site-packages/matplotlib/_path.cpython-39-x86_64-linux-gnu.so: undefined symbol: _ZN3agg10curve3_div4initEdddddd)

likewise on other platforms

same or similar to matplotlib/matplotlib#28357

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 18, 2024

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 18, 2024

Backed out the contourpy/matplotlib updates.

@saraedum
Copy link
Member

The explanation for the needs work label is here: https://groups.google.com/g/sage-devel/c/sVcJiJdUxRs/m/_KdKoPRrBgAJ

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 21, 2024

I've responded in the same place.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 21, 2024

No, it does not "need work".

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 22, 2024

The manipulation of labels will stop.

@kwankyu
Copy link
Collaborator

kwankyu commented Aug 24, 2024

@tobiasdiez scipy is a dependency of the distribution package sagemath-standard. As explained in the comment, scipy imposes certain constrains on cython. So it is reasonable to reflect those constraints into src/pyproject.toml. No?

@kwankyu
Copy link
Collaborator

kwankyu commented Sep 6, 2024

@tobiasdiez scipy is a dependency of the distribution package sagemath-standard. As explained in the comment, scipy imposes certain constrains on cython. So it is reasonable to reflect those constraints into src/pyproject.toml. No?

I can now answer to this. After Tobias's PR #36982, src/pyproject.toml is the source of the version constraints on some dependencies (in this case, cython) of sage-the-distribution. So yes.

This may impose a version constraint stricter than necessary on the dependency of sagemath-standard. However, according to Matthias: #37902 (comment), it is dubious whether sagemath-standard gets real harm from the stricter version constraint.

Anyway there is no mechanism in sage that can be used to maintain two sets of version constraints, one for sage-the-distribution and one for modularized distributions.

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well. LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 28, 2024
sagemathgh-38705: update openblas to 0.3.28
    
probably needed for macOS 15.0
See https://groups.google.com/d/msgid/sage-
devel/21f2c768-c732-46d3-aef4-be86d2b42c1cn%40googlegroups.com

This picks a small part from sagemath#38227
### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
    
URL: sagemath#38705
Reported by: Dima Pasechnik
Reviewer(s): Kwankyu Lee
@saraedum
Copy link
Member

saraedum commented Nov 4, 2024

Closing as this is continued as #38846.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: packages: standard disputed PR is waiting for community vote, see https://groups.google.com/g/sage-devel/c/IgBYUJl33SQ v: moderate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

using numpy 2.0
4 participants