Skip to content

Conversation

dimpase
Copy link
Member

@dimpase dimpase commented Jun 13, 2024

This will fix #38159

Add a missing test

📝 Checklist

  • [ x] The title is concise and informative.
  • [ x] The description explains in detail what this PR is about.
  • [ x] I have linked a relevant issue or discussion.
  • [ x] I have created tests covering the changes.
  • [ ] I have updated the documentation and checked the documentation preview.

⌛ Dependencies

#38163

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM.

Copy link

github-actions bot commented Jun 13, 2024

Documentation preview for this PR (built with commit 6b236b3; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 16, 2024
sagemathgh-38214: test that sagemath#38159 is fixed
    
This will fix sagemath#38159

Add a missing test

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ x] The title is concise and informative.
- [ x] The description explains in detail what this PR is about.
- [ x] I have linked a relevant issue or discussion.
- [ x] I have created tests covering the changes.
- [  ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
sagemath#38163
    
URL: sagemath#38214
Reported by: Dima Pasechnik
Reviewer(s): David Coudert
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 16, 2024
sagemathgh-38214: test that sagemath#38159 is fixed
    
This will fix sagemath#38159

Add a missing test

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ x] The title is concise and informative.
- [ x] The description explains in detail what this PR is about.
- [ x] I have linked a relevant issue or discussion.
- [ x] I have created tests covering the changes.
- [  ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
sagemath#38163
    
URL: sagemath#38214
Reported by: Dima Pasechnik
Reviewer(s): David Coudert
@vbraun vbraun merged commit 11bf188 into sagemath:develop Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong result with tdlib for treewidth
4 participants