bump prompt_toolkit/version_requirements.txt, more spkg-configures #38212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in particular the bump is needed to prevent DeprecationWarning: There is no current event loop loop = asyncio.get_event_loop() as in sagemath#37539
|
Documentation preview for this PR (built with commit ad1cd78; changes) is ready! 🎉 |
|
Best to add a comment to the file that explains the lower version bound. |
|
Yes, that is documented recommendation: https://deploy-livedoc--sagemath.netlify.app/html/en/developer/packaging#abstract-requirements-the-version-requirements-txt-file |
|
it's easy to find: do actually all the info is in the commit message |
kwankyu
reviewed
Jun 13, 2024
| @@ -1 +1 @@ | |||
| prompt_toolkit >=3.0.38 | |||
| prompt_toolkit >=3.0.43 | |||
There was a problem hiding this comment.
Suggested change
| prompt_toolkit >=3.0.43 | |
| # Fedora 40 has an issue with lower version. See #38212. | |
| prompt_toolkit >=3.0.43 |
for future maintainer?
|
This change is useful but actually this warning existed for me in Fedora 39, I do not remember exactly when it disappear but it does not appear for me in Fedora 40. |
|
I got a warning since I used a system version (using |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 16, 2024
sagemathgh-38212: bump prompt_toolkit/version_requirements.txt, more spkg-configures in particular the bump is needed to prevent `DeprecationWarning: There is no current event loop loop = asyncio.get_event_loop()` as in sagemath#37539 On Fedora 40 using old prompt_toolkit from the system not only produces warnings, it hangs `make test` <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x ] The title is concise and informative. - [x ] The description explains in detail what this PR is about. - [x ] I have linked a relevant issue or discussion. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38212 Reported by: Dima Pasechnik Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 16, 2024
sagemathgh-38212: bump prompt_toolkit/version_requirements.txt, more spkg-configures in particular the bump is needed to prevent `DeprecationWarning: There is no current event loop loop = asyncio.get_event_loop()` as in sagemath#37539 On Fedora 40 using old prompt_toolkit from the system not only produces warnings, it hangs `make test` <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x ] The title is concise and informative. - [x ] The description explains in detail what this PR is about. - [x ] I have linked a relevant issue or discussion. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38212 Reported by: Dima Pasechnik Reviewer(s): Kwankyu Lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in particular the bump is needed to prevent
DeprecationWarning: There is no current event loop loop = asyncio.get_event_loop()as in #37539
On Fedora 40 using old prompt_toolkit from the system not only produces warnings, it hangs
make test📝 Checklist
⌛ Dependencies