Skip to content

Lint: Install tox from ubuntu, as done in CI Build&Test etc. #38206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2024
Merged

Lint: Install tox from ubuntu, as done in CI Build&Test etc. #38206

merged 1 commit into from
Jun 22, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jun 12, 2024

... instead of via pip.
This is for uniformity and motivated by stability concerns prompted by #38205

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 05ae41f; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@kwankyu
Copy link
Collaborator

kwankyu commented Jun 13, 2024 •
edited
Loading

The situation is that pip-installed tox fails in auto-provisioning (upgrading) itself because of incompatible version of filelock, and the distribution-provided tox is supposed to be more stable and immune from this kind of instability. Am I right?

@kwankyu
Copy link
Collaborator

kwankyu commented Jun 13, 2024

Is there a test run?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 13, 2024

The situation is that pip-installed tox fails in auto-provisioning (upgrading) itself because of incompatible version of filelock, and the distribution-provided tox is supposed to be more stable and immune from this kind of instability. Am I right?

Yes, that's right.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 13, 2024

A test run (when there was still a broken filelock on PyPI): https://github.com/sagemath/sage/actions/runs/9488101498/job/26146233900

kwankyu
kwankyu approved these changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 13, 2024

Thanks!

vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 16, 2024
937e4fd 
sagemathgh-38206: Lint: Install tox from ubuntu, as done in CI Build&Test etc.
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

... instead of via pip.
This is for uniformity and motivated by stability concerns prompted by
sagemath#38205

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38206
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 16, 2024
a0d3264 
sagemathgh-38206: Lint: Install tox from ubuntu, as done in CI Build&Test etc.
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

... instead of via pip.
This is for uniformity and motivated by stability concerns prompted by
sagemath#38205

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#38206
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
@vbraun vbraun merged commit 8fea1cf into sagemath:develop Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

Assignees

@mkoeppe mkoeppe

Labels
c: scripts p: minor / 4 v: minimal
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoeppe @kwankyu @vbraun