Replace uses of setup.py bdist_wheel and direct uses of python3 -m build
#38201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
June 22, 2024 16:11
…wheel --sdist-then-wheel
…tall.in: Use sdh_build_and_store_wheel
|
Documentation preview for this PR (built with commit 0878cc2; changes) is ready! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the next step in the modernization of our use of build front ends for Python SPKGs, after #35618.
sage-dist-helperfunctionssdh_build_wheel,sdh_build_and_store_wheel(split out frompkgs/sagemath-doc-{html,pdf}#36730)--sdist-then-wheelforsdh_pip_install(and the newsdh_build*wheelfunctions)By switching the packages
sagemath_environmentetc. from direct use ofpython3 -m buildto thesdh_build_and_store_wheelscript, it now falls back to--no-build-isolationwhen building with build isolation fails.📝 Checklist
⌛ Dependencies