Skip to content

Filter out R warnings #38294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 16, 2024
Merged

Filter out R warnings #38294

merged 3 commits into from
Jul 16, 2024

Conversation

antonio-rojas
Copy link
Contributor

These are causing some doctest failures after #35396

**********************************************************************
File "/usr/lib/python3.12/site-packages/sage/interfaces/r.py", line 51, in sage.interfaces.r
Failed example:
    v = 2*x+y+1; v
Expected:
    [1] 32.2 17.8 10.3 20.2 66.1 21.8 22.6 12.8 16.9 50.8 43.5
Got:
    R[write to console]: Además: 
    R[write to console]: Aviso:
    <BLANKLINE>
    R[write to console]: In sage10 + sage6 :
    R[write to console]: 
    <BLANKLINE>
    R[write to console]:  longitud de objeto mayor no es múltiplo de la longitud de uno menor
    <BLANKLINE>
     [1] 32.2 17.8 10.3 20.2 66.1 21.8 22.6 12.8 16.9 50.8 43.5
**********************************************************************
File "/usr/lib/python3.12/site-packages/sage/interfaces/r.py", line 78, in sage.interfaces.r
Failed example:
    r(-17).sqrt()
Expected:
    [1] NaN
Got:
    R[write to console]: Además: 
    R[write to console]: Aviso:
    <BLANKLINE>
    R[write to console]: In sqrt(sage10) :
    R[write to console]:  Se han producido NaNs
    <BLANKLINE>
    [1] NaN
**********************************************************************
File "/usr/lib/python3.12/site-packages/sage/interfaces/r.py", line 356, in sage.interfaces.r._setup_r_to_sage_converter
Failed example:
    r(-17).sqrt().sage()
Expected:
    nan
Got:
    R[write to console]: Además: 
    R[write to console]: Aviso:
    <BLANKLINE>
    R[write to console]: In sqrt(sage4) :
    R[write to console]:  Se han producido NaNs
    <BLANKLINE>
    nan
**********************************************************************

@antonio-rojas
Filter out R warnings
db5bf6c 
These are causing some doctest failures after sagemath#35396
@antonio-rojas antonio-rojas requested a review from mkoeppe June 27, 2024 16:42
mkoeppe
mkoeppe approved these changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@vbraun
Copy link
Member

vbraun commented Jul 9, 2024

Merge conflict

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 10, 2024

Simple merge

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 10, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 23497d0; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

vbraun pushed a commit to vbraun/sage that referenced this pull request Jul 13, 2024
sagemathgh-38294: Filter out R warnings
28d8530 
These are causing some doctest failures after
sagemath#35396

```
**********************************************************************
File "/usr/lib/python3.12/site-packages/sage/interfaces/r.py", line 51,
in sage.interfaces.r
Failed example:
    v = 2*x+y+1; v
Expected:
    [1] 32.2 17.8 10.3 20.2 66.1 21.8 22.6 12.8 16.9 50.8 43.5
Got:
    R[write to console]: Además:
    R[write to console]: Aviso:
    <BLANKLINE>
    R[write to console]: In sage10 + sage6 :
    R[write to console]:
    <BLANKLINE>
    R[write to console]:  longitud de objeto mayor no es múltiplo de la
longitud de uno menor
    <BLANKLINE>
     [1] 32.2 17.8 10.3 20.2 66.1 21.8 22.6 12.8 16.9 50.8 43.5
**********************************************************************
File "/usr/lib/python3.12/site-packages/sage/interfaces/r.py", line 78,
in sage.interfaces.r
Failed example:
    r(-17).sqrt()
Expected:
    [1] NaN
Got:
    R[write to console]: Además:
    R[write to console]: Aviso:
    <BLANKLINE>
    R[write to console]: In sqrt(sage10) :
    R[write to console]:  Se han producido NaNs
    <BLANKLINE>
    [1] NaN
**********************************************************************
File "/usr/lib/python3.12/site-packages/sage/interfaces/r.py", line 356,
in sage.interfaces.r._setup_r_to_sage_converter
Failed example:
    r(-17).sqrt().sage()
Expected:
    nan
Got:
    R[write to console]: Además:
    R[write to console]: Aviso:
    <BLANKLINE>
    R[write to console]: In sqrt(sage4) :
    R[write to console]:  Se han producido NaNs
    <BLANKLINE>
    nan
**********************************************************************
```

URL: sagemath#38294
Reported by: Antonio Rojas
Reviewer(s): Matthias Köppe
@vbraun vbraun merged commit 89d1d65 into sagemath:develop Jul 16, 2024
@antonio-rojas antonio-rojas deleted the r-tests branch July 17, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mkoeppe mkoeppe mkoeppe approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
p: blocker / 1 v: minimal
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
4 participants
@antonio-rojas @vbraun @mkoeppe @kwankyu