Fix hashing for Weyl algebra elements #38119
Conversation
|
Documentation preview for this PR (built with commit 12162b2; changes) is ready! 🎉 |
There was a problem hiding this comment.
The _richcmp_ and __init__ are no longer needed as it will be inherited from IndexedFreeModuleElement. Please keep the doctests somewhere though.
These methods are also unnecessary but can simply be removed: _add_, __neg__, monomial_coefficients, support,
Please add a test showing the left and right multiplication of the Weyl algebra by the corresponding polynomial ring generates the correct results. I am slightly worried about the _acted_upon_ versus _lmul_ and _rmul_ not being compatible...
|
Good points. All done -- except for the doctests, which already exist. |
|
Thank you, Travis! |
sagemathgh-38119: Fix hashing for Weyl algebra elements Weyl algebras elements cannot be hashed or compared, since the element class is too barren. This patch lets the element class inherit from IndexedFreeModuleElement, which fixes this problem automatically. URL: sagemath#38119 Reported by: Darij Grinberg Reviewer(s): Travis Scrimshaw
sagemathgh-38119: Fix hashing for Weyl algebra elements Weyl algebras elements cannot be hashed or compared, since the element class is too barren. This patch lets the element class inherit from IndexedFreeModuleElement, which fixes this problem automatically. URL: sagemath#38119 Reported by: Darij Grinberg Reviewer(s): Travis Scrimshaw
sagemathgh-38119: Fix hashing for Weyl algebra elements Weyl algebras elements cannot be hashed or compared, since the element class is too barren. This patch lets the element class inherit from IndexedFreeModuleElement, which fixes this problem automatically. URL: sagemath#38119 Reported by: Darij Grinberg Reviewer(s): Travis Scrimshaw
Weyl algebras elements cannot be hashed or compared, since the element class is too barren.
This patch lets the element class inherit from IndexedFreeModuleElement, which fixes this problem automatically.