Skip to content

Update conway_polynomials, database_cubic_hecke, database_knotinfo, matroid_database #38110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 1, 2024
Merged

Update conway_polynomials, database_cubic_hecke, database_knotinfo, matroid_database #38110

merged 5 commits into from
Jun 1, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented May 29, 2024

Using sage --package update-latest ... --commit.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions GitHub Actions
Copy link

github-actions bot commented May 29, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 4dca61e; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@kwankyu
Copy link
Collaborator

kwankyu commented May 29, 2024

As "CI Linux incremental" is all broken, we cannot test package upgrades. Would it be fixed sooner or later?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 29, 2024

As "CI Linux incremental" is all broken, we cannot test package upgrades.

It does reveal already:

#30 518.4   [conway_polynomials-0.10]   sage_bootstrap.tarball.FileNotMirroredError: tarball does not exist on mirror network and neither at the upstream URL
#30 518.4   [conway_polynomials-0.10]   ************************************************************************
#30 518.4   [conway_polynomials-0.10]   Error downloading tarball of conway_polynomials
#30 518.4   [conway_polynomials-0.10]   ************************************************************************

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 29, 2024

But I hope to fix the workflow soon, on top of #36730

@kwankyu
Copy link
Collaborator

kwankyu commented May 30, 2024

As "CI Linux incremental" is all broken, we cannot test package upgrades.

It does reveal already:

#30 518.4   [conway_polynomials-0.10]   sage_bootstrap.tarball.FileNotMirroredError: tarball does not exist on mirror network and neither at the upstream URL
#30 518.4   [conway_polynomials-0.10]   ************************************************************************
#30 518.4   [conway_polynomials-0.10]   Error downloading tarball of conway_polynomials
#30 518.4   [conway_polynomials-0.10]   ************************************************************************

I meant that package upgrades need portability checks, unless they are python packages.

@kwankyu
Copy link
Collaborator

kwankyu commented May 30, 2024

OK. They are all python packages:

$ sage --package properties conway_polynomials database_cubic_hecke database_knotinfo matroid_database
conway_polynomials:
        path:                        /Users/kwankyu/GitHub/sage-dev/build/pkgs/conway_polynomials
        version_with_patchlevel:     0.8
        type:                        standard
        source:                      normal
        trees:                       SAGE_VENV
        purl:                        pkg:pypi/conway-polynomials
database_cubic_hecke:
        path:                        /Users/kwankyu/GitHub/sage-dev/build/pkgs/database_cubic_hecke
        version_with_patchlevel:     2022.3.1
        type:                        optional
        source:                      normal
        trees:                       SAGE_VENV
        purl:                        pkg:pypi/database-cubic-hecke
database_knotinfo:
        path:                        /Users/kwankyu/GitHub/sage-dev/build/pkgs/database_knotinfo
        version_with_patchlevel:     2024.2.1
        type:                        optional
        source:                      normal
        trees:                       SAGE_VENV
        purl:                        pkg:pypi/database-knotinfo
matroid_database:
        path:                        /Users/kwankyu/GitHub/sage-dev/build/pkgs/matroid_database
        version_with_patchlevel:     0.2
        type:                        optional
        source:                      wheel
        trees:                       SAGE_VENV
        purl:                        pkg:pypi/matroid-database

@kwankyu
Copy link
Collaborator

kwankyu commented May 30, 2024

By the way, I wonder why "matroid_database" is named inconsistently with other database packages named "database_..."...

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 30, 2024

It's true though that the optional database packages are only being tested by the "CI Linux Incremental" workflow, not the "Build & Test" workflow.

kwankyu
kwankyu approved these changes May 30, 2024
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. The optional package upgrades work well on my system.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 31, 2024

Thanks!

@gmou3
Copy link
Contributor

gmou3 commented May 31, 2024

By the way, I wonder why "matroid_database" is named inconsistently with other database packages named "database_..."...

Donno why all others are named database_*, but matroid_database is a fine name in my opinion. It is an external package, not only for sage.

@kwankyu
Copy link
Collaborator

kwankyu commented May 31, 2024

Yes. I understand that now.

@vbraun vbraun merged commit af781fa into sagemath:develop Jun 1, 2024
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 2, 2024

@vbraun Missing file: conway_polynomials-0.10-py3-none-any.whl
https://github.com/sagemath/sage/actions/runs/9333677038/job/25690937943#step:4:3359

@S17A05 S17A05 mentioned this pull request Jun 2, 2024
Closed
2 tasks
@vbraun
Copy link
Member

vbraun commented Jun 2, 2024

should be live now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

@soehms soehms Awaiting requested review from soehms

@orlitzky orlitzky Awaiting requested review from orlitzky

@S17A05 S17A05 Awaiting requested review from S17A05

+1 more reviewer

@gmou3 gmou3 gmou3 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@mkoeppe mkoeppe

Labels
c: packages: optional c: packages: standard v: minimal
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
4 participants
@mkoeppe @kwankyu @gmou3 @vbraun