fix and activate E305 in pyx files #38176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 8e0d14c; changes) is ready! 🎉 |
mkoeppe
reviewed
Jun 10, 2024
| @@ -183,7 +183,7 @@ description = | |||
| # See https://pycodestyle.pycqa.org/en/latest/intro.html#error-codes | |||
| deps = pycodestyle | |||
| commands = pycodestyle --select E111,E21,E221,E222,E225,E227,E228,E25,E271,E303,E305,E306,E401,E502,E701,E702,E703,E71,E72,W291,W293,W391,W605 {posargs:{toxinidir}/sage/} | |||
| pycodestyle --select E111,E271,E301,E306,E401,E502,E703,E712,E713,E714,E72,W29,W391,W605, --filename *.pyx {posargs:{toxinidir}/sage/} | |||
| pycodestyle --select E111,E271,E301,E305,E306,E401,E502,E703,E712,E713,E714,E72,W29,W391,W605, --filename *.pyx {posargs:{toxinidir}/sage/} | |||
There was a problem hiding this comment.
Also update SAGE_ROOT/.vscode/settings.json please
There was a problem hiding this comment.
it seems that there is nothing in there to be modified. No idea if this has been moved or removed
There was a problem hiding this comment.
You are right; pycodestyle has been replaced by ruff there.
Then let's please remove the comment in the file that instructs people to update settings.json ....
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 16, 2024
sagemathgh-38176: fix and activate E305 in pyx files this is adding the pycodestyle E305 check to pycodestyle-minimal in pyx files ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#38176 Reported by: Frédéric Chapoton Reviewer(s): Frédéric Chapoton, Matthias Köppe
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 16, 2024
sagemathgh-38176: fix and activate E305 in pyx files this is adding the pycodestyle E305 check to pycodestyle-minimal in pyx files ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#38176 Reported by: Frédéric Chapoton Reviewer(s): Frédéric Chapoton, Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is adding the pycodestyle E305 check to pycodestyle-minimal in pyx files
📝 Checklist