configure.ac: Check symlinks in the source tree #38039
Conversation
|
Documentation preview for this PR (built with commit 53caf37; changes) is ready! 🎉 |
| @@ -173,19 +173,19 @@ AC_MSG_CHECKING([the symbolic links in the source tree]) | |||
| AS_IF([test -L build/pkgs/liblzma/package-version.txt], [dnl OK | |||
| AC_MSG_RESULT([intact]) | |||
There was a problem hiding this comment.
Is build/pkgs/liblzma/package-version.txt right? Isn't it build/pkgs/sagelib/src?
There was a problem hiding this comment.
Perhaps it doesn't matter. But as we also expect that build/pkgs/sagelib/src is a symbolic link and because subsequent checks are also about build/pkgs/sagelib/src, it is a bit confusing...
There was a problem hiding this comment.
The tests are designed so that they also work when the configure script runs out of pkgs/sage-conf_pypi. In this distribution, there is no symlink build/pkgs/sagelib/src.
There was a problem hiding this comment.
OK. At least I can see that the test passes for ordinary sdist case at line 174 and sage-conf_pypi case at line 178, and otherwise something is wrong.
|
Thanks! |
This is to alert users on WSL early about a source tree that has not been cloned correctly.
This will save users from running into build errors later, such as the one reported in https://groups.google.com/g/sage-devel/c/I6_yXdtMwQk/m/xQZoZFSGBgAJ
Fixes #37117
📝 Checklist
⌛ Dependencies