-
-
Notifications
You must be signed in to change notification settings - Fork 656
cython-lint for schemes #38036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cython-lint for schemes #38036
Conversation
Documentation preview for this PR (built with commit e436cb9; changes) is ready! 🎉 |
ok, voila. Merci pour la relecture, David. Je ne pretends pas avoir tout corrigé, loin de la. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. However, this PR is not yet in needs review
. Is it ready ?
ben, oui, mais l'integration continue est totalement cassée et tout le monde s'en fiche.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So then, LGTM.
fixing a few more cython-lint suggestions in schemes
cython-lint --ignore=E501,E231,E265 src/sage/schemes/
📝 Checklist