Skip to content

Conversation

fchapoton
Copy link
Contributor

fixing a few more cython-lint suggestions in schemes

cython-lint --ignore=E501,E231,E265 src/sage/schemes/

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

Copy link

github-actions bot commented May 20, 2024

Documentation preview for this PR (built with commit e436cb9; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@fchapoton
Copy link
Contributor Author

ok, voila. Merci pour la relecture, David. Je ne pretends pas avoir tout corrigé, loin de la.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, this PR is not yet in needs review. Is it ready ?

@fchapoton
Copy link
Contributor Author

ben, oui, mais l'integration continue est totalement cassée et tout le monde s'en fiche..

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So then, LGTM.

@vbraun vbraun merged commit b17bc6f into sagemath:develop May 25, 2024
@fchapoton fchapoton deleted the cylint_more_schemes branch May 25, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants