Skip to content

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented May 18, 2024

These fix the build on macOS, as discussed in #38020.

Test run: https://github.com/mkoeppe/sage/actions/runs/9142716213/job/25138580652

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

faisalfakhro and others added 26 commits April 25, 2024 17:30
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 18, 2024

Tests (ci-37203-37834-37840-37919-37931-38008-38009-38020-38021-38025) at https://github.com/mkoeppe/sage/actions/runs/9142716213

Copy link

github-actions bot commented May 18, 2024

Documentation preview for this PR (built with commit a8a8dd8; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@kwankyu
Copy link
Collaborator

kwankyu commented May 19, 2024

This works well. Together with #38021, the build succeeded on my system.

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 19, 2024

Thank you! Also one of the CI runs just completed: https://github.com/mkoeppe/sage/actions/runs/9142716213/job/25139831922

@kwankyu kwankyu mentioned this pull request May 21, 2024
5 tasks
@vbraun vbraun merged commit 886fb1d into sagemath:develop May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants