Implemented a generator for Möbius ladder graph #38084
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit bef114a; changes) is ready! 🎉 |
dcoudert
reviewed
May 27, 2024
|
In the following line at line number 1164 it will be great if Could you please mention how to do that? |
dcoudert
reviewed
Jun 1, 2024
dcoudert
suggested changes
Jun 8, 2024
|
Also, is it fine if we itemize the EXAMPLES with bullets since there are two of them? That is, instead of and we may have the following: and respectively. |
No, we don't need bullets here. See how the documentation looks like. |
|
Could you please let me know why Build & Test / test-long (src/sage/[g-o]*) (pull_request) is failing and how to rerun it? |
|
an unexpected error when running |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 10, 2024
sagemathgh-38084: Implemented a generator for Möbius ladder graph <!-- ^ Please provide a concise and informative title. --> This PR adds a generator for Möbius ladder graph. <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> This PR introduces a new static method, specifically `MoebiusLadderGraph`, that considers a non negative integer *n* as the input and returns the Möbius ladder graph of order *2n*. This also includes the required documentation concerning the same. <!-- v Why is this change required? What problem does it solve? --> It adds a new feature, that is $-$ a generator for Möbius ladder graph. <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Fixes sagemath#38083. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> Nothing as of now (up to my knowledge). <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> cc: @dcoudert . URL: sagemath#38084 Reported by: Janmenjaya Panda Reviewer(s): David Coudert, Janmenjaya Panda
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 16, 2024
sagemathgh-38084: Implemented a generator for Möbius ladder graph <!-- ^ Please provide a concise and informative title. --> This PR adds a generator for Möbius ladder graph. <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> This PR introduces a new static method, specifically `MoebiusLadderGraph`, that considers a non negative integer *n* as the input and returns the Möbius ladder graph of order *2n*. This also includes the required documentation concerning the same. <!-- v Why is this change required? What problem does it solve? --> It adds a new feature, that is $-$ a generator for Möbius ladder graph. <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Fixes sagemath#38083. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> Nothing as of now (up to my knowledge). <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> cc: @dcoudert . URL: sagemath#38084 Reported by: Janmenjaya Panda Reviewer(s): David Coudert, Janmenjaya Panda
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 16, 2024
sagemathgh-38084: Implemented a generator for Möbius ladder graph <!-- ^ Please provide a concise and informative title. --> This PR adds a generator for Möbius ladder graph. <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> This PR introduces a new static method, specifically `MoebiusLadderGraph`, that considers a non negative integer *n* as the input and returns the Möbius ladder graph of order *2n*. This also includes the required documentation concerning the same. <!-- v Why is this change required? What problem does it solve? --> It adds a new feature, that is $-$ a generator for Möbius ladder graph. <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Fixes sagemath#38083. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> Nothing as of now (up to my knowledge). <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> cc: @dcoudert . URL: sagemath#38084 Reported by: Janmenjaya Panda Reviewer(s): David Coudert, Janmenjaya Panda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a generator for Möbius ladder graph.
This PR introduces a new static method, specifically
MoebiusLadderGraph, that considers a non negative integer n as the input and returns the Möbius ladder graph of order 2n. This also includes the required documentation concerning the same.It adds a new feature, that is$-$ a generator for Möbius ladder graph.
Fixes #38083.
📝 Checklist
⌛ Dependencies
Nothing as of now (up to my knowledge).
cc: @dcoudert .