Skip to content

Conversation

kwankyu
Copy link
Collaborator

@kwankyu kwankyu commented May 21, 2024

Once again, we fix changes.html, currently broken in every PR. For example, follow #38041 (comment)

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@kwankyu kwankyu changed the title Do not add html to form path Fix wrong urls in changes.html May 21, 2024
@kwankyu kwankyu requested a review from mkoeppe May 21, 2024 13:48
Copy link

Documentation preview for this PR (built with commit d484ac0; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@mkoeppe
Copy link
Contributor

mkoeppe commented May 21, 2024

Thanks for the fix.
Did I break this?

@kwankyu
Copy link
Collaborator Author

kwankyu commented May 22, 2024

Perhaps, when you made changes to how doc diffs are made... As far as I remember,

It got broken once, and to fix it, I inserted path = 'html/' + doc.

It is broken once again, and I am reverting the previous fix by path = doc.

Now all looks good :-)

@vbraun vbraun merged commit c2b63fc into sagemath:develop May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: CI Fix merged before running CI tests p: critical / 2 v: minimal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants