Skip to content

Conversation

fchapoton
Copy link
Contributor

Simplify the handling of dead OEIS sequences. Trying to ignore them, mostly.

This fixes #38044

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

Copy link

Documentation preview for this PR (built with commit 9cdde03; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@kwankyu
Copy link
Collaborator

kwankyu commented May 22, 2024

Trying to ignore them, mostly.

I am not sure if this is desirable.

(1) When we search for oeis items for a given sequence, then dead items should be ignored, of course.

(2) But when we request data about a dead item, then it is right to warn the user.

To implement (1), is_dead() method should be an exception to (2) -- is_dead() should never raise a warning. But I think all other methods should behave according to (2).

Isn't this enough to solve #38044?

@fchapoton
Copy link
Contributor Author

I would prefer strongly to do exactly what I did. If somebody asks for data using the A-number of a dead sequence, it is his own responsability. No need for a warning.

@kwankyu
Copy link
Collaborator

kwankyu commented May 22, 2024

All right. I will leave the design to you and @PeterLuschny, as I have had no occasion to use OEIS.

I looked through the code, and have no other comments.

@PeterLuschny
Copy link

Looks fine to me!
Thanks!

@fchapoton
Copy link
Contributor Author

so may I set to positive review in your name, if you cannot do it yourself ?

@PeterLuschny
Copy link

@fchapoton

so may I set to positive review in your name, if you cannot do it yourself ?
Yes please!
Sorry that I'm very clumsy in dealing with the request/issue/review things.

@fchapoton
Copy link
Contributor Author

ok, done.

@vbraun vbraun merged commit 81c1fd9 into sagemath:develop May 25, 2024
@fchapoton fchapoton deleted the dead_oeis_seq branch May 25, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore sequences with the keyword 'dead' when reading the OEIS database.
5 participants