Skip to content

Conversation

vbraun
Copy link
Member

@vbraun vbraun commented May 5, 2024

Actual output (gcc 14 + cython 3.10):

error: assignment to 'PyObject *' {aka 'struct _object *'} from incompatible pointer type 'struct __pyx_obj_4sage_4plot_6plot3d_16implicit_surface_VertexInfo *' [-Wincompatible-pointer-types
```

Actual output:

error: assignment to 'PyObject *' {aka 'struct _object *'} from incompatible pointer type 'struct __pyx_obj_4sage_4plot_6plot3d_16implicit_surface_VertexInfo *' [-Wincompatible-pointer-types
@vbraun vbraun mentioned this pull request May 5, 2024
2 tasks
Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good enough

Copy link

github-actions bot commented May 8, 2024

Documentation preview for this PR (built with commit cec595e; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

vbraun pushed a commit to vbraun/sage that referenced this pull request May 9, 2024
sagemathgh-37939: Fix incompatible pointer type assignment error in implicit_surface
    
Actual output (gcc 14 + cython 3.10):
````
error: assignment to 'PyObject *' {aka 'struct _object *'} from
incompatible pointer type 'struct
__pyx_obj_4sage_4plot_6plot3d_16implicit_surface_VertexInfo *'
[-Wincompatible-pointer-types
```
    
URL: sagemath#37939
Reported by: Volker Braun
Reviewer(s): Dima Pasechnik, Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request May 11, 2024
sagemathgh-37939: Fix incompatible pointer type assignment error in implicit_surface
    
Actual output (gcc 14 + cython 3.10):
````
error: assignment to 'PyObject *' {aka 'struct _object *'} from
incompatible pointer type 'struct
__pyx_obj_4sage_4plot_6plot3d_16implicit_surface_VertexInfo *'
[-Wincompatible-pointer-types
```
    
URL: sagemath#37939
Reported by: Volker Braun
Reviewer(s): Dima Pasechnik, Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request May 12, 2024
sagemathgh-37939: Fix incompatible pointer type assignment error in implicit_surface
    
Actual output (gcc 14 + cython 3.10):
````
error: assignment to 'PyObject *' {aka 'struct _object *'} from
incompatible pointer type 'struct
__pyx_obj_4sage_4plot_6plot3d_16implicit_surface_VertexInfo *'
[-Wincompatible-pointer-types
```
    
URL: sagemath#37939
Reported by: Volker Braun
Reviewer(s): Dima Pasechnik, Frédéric Chapoton
@vbraun vbraun merged commit 5d12c34 into sagemath:develop May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants