.github/workflows/docker_hub.yml: Do not fail when there are no credentials
#37986
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit ffabaaf; changes) is ready! 🎉 |
|
I will have a look at it in connection with #37856 (comment). |
kwankyu
reviewed
May 22, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes I push mock release tags to my repo to test workflows relevant to making a release.
Currently, the workflow "Build Docker images and push to DockerHub" fails in this situation when it tries to log in to DockerHub; example: https://github.com/mkoeppe/sage/actions/runs/9045501088/job/24855325483
This PR modifies it to just skip the "login" step when the secrets are not set. It then still builds the image, but does not try to push. Example: https://github.com/mkoeppe/sage/actions/runs/9046681672/job/24857769764
📝 Checklist
⌛ Dependencies