Skip to content

Adding add_bigoh methods to lazy power/Laurent series and coercions to the finite precision implementations #37952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 25, 2024
Merged

Adding add_bigoh methods to lazy power/Laurent series and coercions to the finite precision implementations #37952

merged 3 commits into from
May 25, 2024

Conversation

tscrim
Copy link
Collaborator

@tscrim tscrim commented May 7, 2024

It is natural to go from the lazy series (infinite precision) to the finite precision cases. We provide these coercion maps and the analogous methods add_bigoh and O for better compatibility.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@tscrim tscrim requested a review from mantepse May 7, 2024 05:55
@mantepse
Copy link
Contributor

mantepse commented May 9, 2024

There is a doctest failure in laurent_series_ring.py

@tscrim tscrim removed the v: small label May 10, 2024
@tscrim
Copy link
Collaborator Author

tscrim commented May 10, 2024

Fixed.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 10, 2024 •
edited
Loading

Documentation preview for this PR (built with commit e171ec5; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

mantepse
mantepse approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@mantepse mantepse left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to ignore the comment as you wish and set it to positive review after your decision.

mantepse
mantepse approved these changes May 12, 2024
View reviewed changes
Copy link
Contributor

@mantepse mantepse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tscrim
Copy link
Collaborator Author

tscrim commented May 12, 2024

Thank you.

vbraun pushed a commit to vbraun/sage that referenced this pull request May 15, 2024
69df78c 
sagemathgh-37952: Adding add_bigoh methods to lazy power/Laurent series and coercions to the finite precision implementations
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

It is natural to go from the lazy series (infinite precision) to the
finite precision cases. We provide these coercion maps and the analogous
methods `add_bigoh` and `O` for better compatibility.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37952
Reported by: Travis Scrimshaw
Reviewer(s): Martin Rubey, Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request May 18, 2024
c0fb088 
sagemathgh-37952: Adding add_bigoh methods to lazy power/Laurent series and coercions to the finite precision implementations
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

It is natural to go from the lazy series (infinite precision) to the
finite precision cases. We provide these coercion maps and the analogous
methods `add_bigoh` and `O` for better compatibility.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37952
Reported by: Travis Scrimshaw
Reviewer(s): Martin Rubey, Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request May 18, 2024
4a1fbaa 
sagemathgh-37952: Adding add_bigoh methods to lazy power/Laurent series and coercions to the finite precision implementations
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

It is natural to go from the lazy series (infinite precision) to the
finite precision cases. We provide these coercion maps and the analogous
methods `add_bigoh` and `O` for better compatibility.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37952
Reported by: Travis Scrimshaw
Reviewer(s): Martin Rubey, Travis Scrimshaw
@vbraun vbraun merged commit 8d871d3 into sagemath:develop May 25, 2024
@tscrim tscrim deleted the lazy_series/add_bigoh branch May 28, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mantepse mantepse mantepse approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: commutative algebra p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
4 participants
@tscrim @mantepse @vbraun @mkoeppe