Skip to content

FreeModuleHomset: Create subclass FreeModuleEndset, add element methods for invariants det, charpoly, fcp, etc. #37831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 12, 2024
Merged

FreeModuleHomset: Create subclass FreeModuleEndset, add element methods for invariants det, charpoly, fcp, etc. #37831

merged 8 commits into from
May 12, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Apr 19, 2024 •
edited
Loading

We create

  • a parent subclass FreeModuleEndset (of FreeModuleHomset)
  • an element subclass FiniteRankFreeModuleEndomorphism (of FiniteRankFreeModuleMorphism)

for the purpose of providing specific methods of endomorphisms, namely the endomorphism invariants det, trace, charpoly, etc.

This is parallel to what is done

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 19, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 1fab17d; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

tscrim
tscrim requested changes Apr 22, 2024
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The __classcall_private__ needs a doctest. Otherwise LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 22, 2024

The __classcall_private__ needs a doctest.

Thanks for catching this, done in abc6572

tscrim
tscrim approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 23, 2024

Thank you!

egourgoulhon
egourgoulhon reviewed Apr 24, 2024
View reviewed changes
egourgoulhon
egourgoulhon reviewed Apr 24, 2024
View reviewed changes
egourgoulhon
egourgoulhon reviewed Apr 24, 2024
View reviewed changes
egourgoulhon
egourgoulhon reviewed Apr 24, 2024
View reviewed changes
egourgoulhon
egourgoulhon suggested changes Apr 24, 2024
View reviewed changes
Copy link
Member

@egourgoulhon egourgoulhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well. I have only minor suggestions.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 25, 2024

Thanks a lot for these edits!

egourgoulhon
egourgoulhon approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@egourgoulhon egourgoulhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 3, 2024

trivial rebase

vbraun pushed a commit to vbraun/sage that referenced this pull request May 4, 2024
05100c9 
sagemathgh-37831: `FreeModuleHomset`: Create subclass `FreeModuleEndset`, add element methods for invariants `det`, `charpoly`, `fcp`, etc.
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

We create
- a parent subclass `FreeModuleEndset` (of `FreeModuleHomset`)
- an element subclass `FiniteRankFreeModuleEndomorphism` (of
`FiniteRankFreeModuleMorphism`)

for the purpose of providing specific methods of endomorphisms, namely
the endomorphism invariants `det`, `trace`, `charpoly`, etc.

This is parallel to what is done
- for ModulesWithBasis in sagemath#37731
- in sagemath#37826

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37831
Reported by: Matthias Köppe
Reviewer(s): Eric Gourgoulhon, Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request May 9, 2024
018d550 
sagemathgh-37831: `FreeModuleHomset`: Create subclass `FreeModuleEndset`, add element methods for invariants `det`, `charpoly`, `fcp`, etc.
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

We create
- a parent subclass `FreeModuleEndset` (of `FreeModuleHomset`)
- an element subclass `FiniteRankFreeModuleEndomorphism` (of
`FiniteRankFreeModuleMorphism`)

for the purpose of providing specific methods of endomorphisms, namely
the endomorphism invariants `det`, `trace`, `charpoly`, etc.

This is parallel to what is done
- for ModulesWithBasis in sagemath#37731
- in sagemath#37826

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37831
Reported by: Matthias Köppe
Reviewer(s): Eric Gourgoulhon, Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request May 11, 2024
fdc799d 
sagemathgh-37831: `FreeModuleHomset`: Create subclass `FreeModuleEndset`, add element methods for invariants `det`, `charpoly`, `fcp`, etc.
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

We create
- a parent subclass `FreeModuleEndset` (of `FreeModuleHomset`)
- an element subclass `FiniteRankFreeModuleEndomorphism` (of
`FiniteRankFreeModuleMorphism`)

for the purpose of providing specific methods of endomorphisms, namely
the endomorphism invariants `det`, `trace`, `charpoly`, etc.

This is parallel to what is done
- for ModulesWithBasis in sagemath#37731
- in sagemath#37826

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37831
Reported by: Matthias Köppe
Reviewer(s): Eric Gourgoulhon, Travis Scrimshaw
vbraun pushed a commit to vbraun/sage that referenced this pull request May 12, 2024
246aefe 
sagemathgh-37831: `FreeModuleHomset`: Create subclass `FreeModuleEndset`, add element methods for invariants `det`, `charpoly`, `fcp`, etc.
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

We create
- a parent subclass `FreeModuleEndset` (of `FreeModuleHomset`)
- an element subclass `FiniteRankFreeModuleEndomorphism` (of
`FiniteRankFreeModuleMorphism`)

for the purpose of providing specific methods of endomorphisms, namely
the endomorphism invariants `det`, `trace`, `charpoly`, etc.

This is parallel to what is done
- for ModulesWithBasis in sagemath#37731
- in sagemath#37826

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37831
Reported by: Matthias Köppe
Reviewer(s): Eric Gourgoulhon, Travis Scrimshaw
@vbraun vbraun merged commit fd4465f into sagemath:develop May 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

+1 more reviewer

@egourgoulhon egourgoulhon egourgoulhon approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@mkoeppe mkoeppe

Labels
c: linear algebra
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
4 participants
@mkoeppe @egourgoulhon @tscrim @vbraun