Skip to content

Conversation

fchapoton
Copy link
Contributor

mostly about pep8 code formatting, also a few unused declarations and variables

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

Copy link

github-actions bot commented Apr 14, 2024

Documentation preview for this PR (built with commit 68e0c9e; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

Copy link
Contributor

@dcoudert dcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

vbraun pushed a commit to vbraun/sage that referenced this pull request Apr 28, 2024
sagemathgh-37800: some cython-lint suggestions fixed in real rings
    
mostly about pep8 code formatting, also a few unused declarations and
variables

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#37800
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert
@vbraun vbraun merged commit abad24f into sagemath:develop May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants