sage.misc.package: Remove deprecated code
#37855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 23, 2024 12:36
|
Documentation preview for this PR (built with commit 9221a32; changes) is ready! 🎉 |
kiwifb
reviewed
Apr 25, 2024
| @@ -40,8 +40,7 @@ | |||
| lazy_import('sage.misc.dist', 'install_scripts', deprecation=34259) | |||
| lazy_import('sage.misc.trace', 'trace', deprecation=34259) | |||
| lazy_import('sage.misc.package', ('installed_packages', 'is_package_installed', | |||
| 'standard_packages', 'optional_packages', | |||
| 'experimental_packages', 'package_versions'), | |||
| 'package_versions'), | |||
There was a problem hiding this comment.
I suggest we remove lazy_import('sage.misc.package',...) altogether. Those functions are always explicitly imported and only in limited context (setup.py and feature.pkg_systems.py). package_versions is never ever called anywhere anymore which suggests it should be at least deprecated if not removed.
There was a problem hiding this comment.
The import is already deprecated, but it's short of 1 year of deprecation
kiwifb
approved these changes
Apr 25, 2024
|
Thank you! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 28, 2024
sagemathgh-37855: `sage.misc.package`: Remove deprecated code <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> Remove code deprecated in: - sagemath#31013 (2022) - sagemath#30747 (2020) - sagemath#30607 (2020) ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37855 Reported by: Matthias Köppe Reviewer(s): François Bissey, Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove code deprecated in:
sage.misc.package.PackageNotFoundError, is_package_installed by features #30607 (2020)📝 Checklist
⌛ Dependencies