Work around inconsistent iteration in multi_polynomial_sequence.py
#37853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit ded51e1; changes) is ready! 🎉 |
mantepse
reviewed
Apr 23, 2024
mantepse
reviewed
Apr 25, 2024
|
In case you are interested in the boolean polynomial ring, maybe you want to resurrect #26929. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 28, 2024
sagemathgh-37853: Work around inconsistent iteration in `multi_polynomial_sequence.py` When iterating over a `pbori.BooleanPolynomial`, the iterator generates just the monomials, whereas iterating over a `MPolynomial_libsingular` defined over `GF(2)` yields a tuple of the monomial together with its coefficient $1$. This causes issues in the method `.coefficients_monomials()` of `PolynomialSequence_gf2`; we fix said issue by checking ~~whether the iteration yields tuples, in which case we simply replace the tuple by its second element (the actual monomial) in each iteration.~~ which type of polynomial ring we are working in before iterating. Fixes sagemath#37837 (but there might be a more elegant solution). URL: sagemath#37853 Reported by: Sebastian A. Spindler Reviewer(s): Martin Rubey, Sebastian A. Spindler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When iterating over a$1$ . This causes issues in the method
pbori.BooleanPolynomial, the iterator generates just the monomials, whereas iterating over aMPolynomial_libsingulardefined overGF(2)yields a tuple of the monomial together with its coefficient.coefficients_monomials()ofPolynomialSequence_gf2; we fix said issue by checkingwhether the iteration yields tuples, in which case we simply replace the tuple by its second element (the actual monomial) in each iteration.which type of polynomial ring we are working in before iterating.Fixes #37837 (but there might be a more elegant solution).