Skip to content

Implement all G(r,p,m) complex reflection groups #37848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 1, 2024
Merged

Implement all G(r,p,m) complex reflection groups #37848

merged 3 commits into from
Jun 1, 2024

Conversation

tscrim
Copy link
Collaborator

@tscrim tscrim commented Apr 22, 2024

We provide an implementation of the whole family of G(r, p, n) complex reflection groups by realizing them as a subgroup of ColoredPermutations.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@tscrim
Copy link
Collaborator Author

tscrim commented Apr 22, 2024

This has a merge conflict with the splitting of the combinat/all.py. I will deal with that once this is reviewed (if that is still an issue at that time).

@tscrim tscrim requested a review from fchapoton April 22, 2024 03:28
@fchapoton
Copy link
Contributor

where does the merge conflict comes from ? which pull request ?

@fchapoton
Copy link
Contributor

maybe the choice of the name ComplexReflectionGroup is a bit confusing with a category.

@tscrim
Copy link
Collaborator Author

tscrim commented May 10, 2024

It came from the one that split the all.py files, which has then been reverted. So there shouldn’t be a conflict anymore.

It’s the same situation with, e.g., WeylGroup(s). This is most naturally called a complex reflection group at this level of generality; I can’t really call it $G(r,p,n)$. Of course, this isn’t all such groups, but it is the unique infinite family. I guess the $p > 1$ case could be called the ImprimitiveComplexReflectionGroup (with $p=1$ being the colored permutations). What do you think?

@fchapoton
Copy link
Contributor

no, ok, I was just asking. It is indeed reasonable to keep your proposed name, with appropriate documentation

@tscrim tscrim force-pushed the combinat/family_complex_refl_groups branch from 65a8391 to 068040b Compare May 14, 2024 02:05
@tscrim
Copy link
Collaborator Author

tscrim commented May 14, 2024

I thought a bit more, and I found a name that is perhaps reasonable: "Shephard-Todd family complex reflection group" (abbreviated as STFamilyComplexReflectionGroup for the class name).

I added a bit more documentation as well. Let me know if there is anything else you would like changed/added.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 14, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 5c667b2; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@fchapoton
Copy link
Contributor

There is a typo "Klien" instead of Klein.

For the name, I would suggest to keep it shorter. What about "ComplexReflectionG" ?

@tscrim
Copy link
Collaborator Author

tscrim commented May 24, 2024

That makes it seem like I just couldn't type roup. How about ShephardToddFamilyGroup or ShephardToddFamilyCRG?

@fchapoton
Copy link
Contributor

right. 😄

What about ShephardToddFamilyGroup in the class and ShephardToddFamily in the catalog ?

@tscrim tscrim force-pushed the combinat/family_complex_refl_groups branch from 068040b to 5c667b2 Compare May 24, 2024 06:37
@tscrim
Copy link
Collaborator Author

tscrim commented May 24, 2024

Changed. I also removed the global (renamed) import ComplexReflectionGroup and added the hook under groups.misc.ShephardToddFamily. At some point, I want to change the ReflectionGroup to dispatch to these implementations (as well as via CoxeterGroup in the real case), but that is for later.

fchapoton
fchapoton approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, looks good, Thanks

@tscrim
Copy link
Collaborator Author

tscrim commented May 24, 2024

Thank you!

@tscrim tscrim removed the v: large label May 24, 2024
vbraun pushed a commit to vbraun/sage that referenced this pull request May 26, 2024
d391a6e 
sagemathgh-37848: Implement all G(r,p,m) complex reflection groups
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

We provide an implementation of the whole family of `G(r, p, n)` complex
reflection groups by realizing them as a subgroup of
`ColoredPermutations`.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37848
Reported by: Travis Scrimshaw
Reviewer(s): Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request May 27, 2024
2a58419 
sagemathgh-37848: Implement all G(r,p,m) complex reflection groups
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

We provide an implementation of the whole family of `G(r, p, n)` complex
reflection groups by realizing them as a subgroup of
`ColoredPermutations`.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37848
Reported by: Travis Scrimshaw
Reviewer(s): Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request May 29, 2024
fa6986b 
sagemathgh-37848: Implement all G(r,p,m) complex reflection groups
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

We provide an implementation of the whole family of `G(r, p, n)` complex
reflection groups by realizing them as a subgroup of
`ColoredPermutations`.

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37848
Reported by: Travis Scrimshaw
Reviewer(s): Frédéric Chapoton
@vbraun vbraun merged commit 1e38432 into sagemath:develop Jun 1, 2024
@tscrim tscrim deleted the combinat/family_complex_refl_groups branch June 9, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchapoton fchapoton fchapoton approved these changes

Assignees
No one assigned
Labels
c: combinatorics c: group theory t: enhancement
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
4 participants
@tscrim @fchapoton @vbraun @mkoeppe