MatrixMorphism_abstract: Move endomorphism invariants to category
#37731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is an |
|
https://github.com/sagemath/sage/blob/develop/src/sage/categories/modules.py#L818 seems to caution that |
|
Two trivial failures in |
tscrim
reviewed
Apr 6, 2024
| return isinstance(x, FreeModuleMorphism) | ||
|
|
||
|
|
||
| class FreeModuleMorphism(matrix_morphism.MatrixMorphism): | ||
|
|
||
| minimal_polynomial = minpoly = FiniteDimensionalModulesWithBasis.Homsets.Endset.ElementMethods.minimal_polynomial |
There was a problem hiding this comment.
Why is this necessary? Shouldn't this come from the category?
|
Documentation preview for this PR (built with commit 84b0b23; changes) is ready! 🎉 |
added 13 commits
April 17, 2024 21:25
…race}: Add CombinatorialFreeModule examples
…y, minimal_polynomial
…cp to make it compatible with custom charpoly
|
Any further concerns, or can we merge it? |
tscrim
approved these changes
Apr 23, 2024
|
Thanks! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 28, 2024
sagemathgh-37826: FreeModuleAutomorphism: Add more invariants <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> We add more methods that complement the existing methods `det` and `trace`, by delegating to the existing methods of Sage matrices. This is parallel to what is done for ModulesWithBasis in: - sagemath#37731 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37826 Reported by: Matthias Köppe Reviewer(s): Eric Gourgoulhon, Matthias Köppe, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 2, 2024
sagemathgh-37826: FreeModuleAutomorphism: Add more invariants <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> We add more methods that complement the existing methods `det` and `trace`, by delegating to the existing methods of Sage matrices. This is parallel to what is done for ModulesWithBasis in: - sagemath#37731 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37826 Reported by: Matthias Köppe Reviewer(s): Eric Gourgoulhon, Matthias Köppe, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 4, 2024
sagemathgh-37831: `FreeModuleHomset`: Create subclass `FreeModuleEndset`, add element methods for invariants `det`, `charpoly`, `fcp`, etc. <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> We create - a parent subclass `FreeModuleEndset` (of `FreeModuleHomset`) - an element subclass `FiniteRankFreeModuleEndomorphism` (of `FiniteRankFreeModuleMorphism`) for the purpose of providing specific methods of endomorphisms, namely the endomorphism invariants `det`, `trace`, `charpoly`, etc. This is parallel to what is done - for ModulesWithBasis in sagemath#37731 - in sagemath#37826 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37831 Reported by: Matthias Köppe Reviewer(s): Eric Gourgoulhon, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 9, 2024
sagemathgh-37831: `FreeModuleHomset`: Create subclass `FreeModuleEndset`, add element methods for invariants `det`, `charpoly`, `fcp`, etc. <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> We create - a parent subclass `FreeModuleEndset` (of `FreeModuleHomset`) - an element subclass `FiniteRankFreeModuleEndomorphism` (of `FiniteRankFreeModuleMorphism`) for the purpose of providing specific methods of endomorphisms, namely the endomorphism invariants `det`, `trace`, `charpoly`, etc. This is parallel to what is done - for ModulesWithBasis in sagemath#37731 - in sagemath#37826 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37831 Reported by: Matthias Köppe Reviewer(s): Eric Gourgoulhon, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 11, 2024
sagemathgh-37831: `FreeModuleHomset`: Create subclass `FreeModuleEndset`, add element methods for invariants `det`, `charpoly`, `fcp`, etc. <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> We create - a parent subclass `FreeModuleEndset` (of `FreeModuleHomset`) - an element subclass `FiniteRankFreeModuleEndomorphism` (of `FiniteRankFreeModuleMorphism`) for the purpose of providing specific methods of endomorphisms, namely the endomorphism invariants `det`, `trace`, `charpoly`, etc. This is parallel to what is done - for ModulesWithBasis in sagemath#37731 - in sagemath#37826 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37831 Reported by: Matthias Köppe Reviewer(s): Eric Gourgoulhon, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 12, 2024
sagemathgh-37831: `FreeModuleHomset`: Create subclass `FreeModuleEndset`, add element methods for invariants `det`, `charpoly`, `fcp`, etc. <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> We create - a parent subclass `FreeModuleEndset` (of `FreeModuleHomset`) - an element subclass `FiniteRankFreeModuleEndomorphism` (of `FiniteRankFreeModuleMorphism`) for the purpose of providing specific methods of endomorphisms, namely the endomorphism invariants `det`, `trace`, `charpoly`, etc. This is parallel to what is done - for ModulesWithBasis in sagemath#37731 - in sagemath#37826 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37831 Reported by: Matthias Köppe Reviewer(s): Eric Gourgoulhon, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
May 12, 2024
sagemathgh-37831: `FreeModuleHomset`: Create subclass `FreeModuleEndset`, add element methods for invariants `det`, `charpoly`, `fcp`, etc. <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> We create - a parent subclass `FreeModuleEndset` (of `FreeModuleHomset`) - an element subclass `FiniteRankFreeModuleEndomorphism` (of `FiniteRankFreeModuleMorphism`) for the purpose of providing specific methods of endomorphisms, namely the endomorphism invariants `det`, `trace`, `charpoly`, etc. This is parallel to what is done - for ModulesWithBasis in sagemath#37731 - in sagemath#37826 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#37831 Reported by: Matthias Köppe Reviewer(s): Eric Gourgoulhon, Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We move the methods
charpoly,det,fcp,tracefromMatrixMorphism_abstractto theHomsets.Endset.ElementMethodsof the categoryFiniteDimensionalModulesWithBasis. Likewise, we move the methodminpolythere fromFreeModuleMorphism.This makes them also available to endomorphisms of
CombinatorialFreeModule.We also deprecate the functions
is_MatrixMorphism,is_FreeModuleMorphism,is_VectorSpaceMorphism(as part of #32414); they were almost unused.📝 Checklist
⌛ Dependencies