Implement the Jordan decomposition of a matrix and is_semisimple() test #37710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoeppe
approved these changes
Apr 3, 2024
da73fca to
ba94896
Compare
|
Thanks. Indeed, that is a good point about the inexact fields. I have now forbidden it. I also made the checks a bit better for things over nonfields. Actually, I found something that could actually make this a bit better even: https://acl.inf.ethz.ch/people/chrisw/projects/felix/thesis.pdf |
|
This seems to be the best possible algorithm. Sorry for a bit of noise. |
mkoeppe
approved these changes
Apr 3, 2024
|
merge conflict |
ba94896 to
70809e9
Compare
|
Rebased (although I found no merge conflict). |
|
Documentation preview for this PR (built with commit 70809e9; changes) is ready! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We implement the Jordan decomposition of a matrix$A = S + N$ , where $S$ is a semisimple matrix and $N$ is a nilpotent matrix. We also implement a check for the matrix being semisimple by using the
minpoly()being square-free.📝 Checklist
⌛ Dependencies