Skip to content

Fix scaling of vector space morphisms on the left #37709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Fix scaling of vector space morphisms on the left #37709

wants to merge 7 commits into from

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Mar 31, 2024 •
edited
Loading

Based on a rebased version of the first commit (328125f6292de28326dda0e2497c2474aa54c7b7 from #28272 by @tscrim

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

tscrim
tscrim requested changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe you still need a test to check that right (now other) is a MatrixMorphism. The coercion only guarantees that they have the same parent, but homspaces can use multiple types of element classes.

@tscrim
Copy link
Collaborator

tscrim commented Apr 4, 2024

I am pretty sure you pushed things to the wrong branch with the last two commits.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 4, 2024

No, I used it as a test case for:

@tscrim
Copy link
Collaborator

tscrim commented Apr 4, 2024

I see. Well, then until this is a clean branch, I will hold off on finishing the review.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 798a69c; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@mkoeppe mkoeppe

Labels
c: linear algebra s: needs review v: moderate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't scale vector space morphisms on the left Can't multiply a linear morphism defined by a matrix by an element of the base field
2 participants
@mkoeppe @tscrim