various changes about is_field and is_ring #37783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tscrim
approved these changes
Apr 11, 2024
|
not yet ready for consumption ; I need to add a default |
|
I have decided just to fix the doctests here. |
|
Documentation preview for this PR (built with commit b807676; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 20, 2024
sagemathgh-37783: various changes about is_field and is_ring just miscellanous changes about not using `is_ring`, replacing some `is_field` by `in Fields` and having more precise categories in descent algebras also sorting the imports on the way ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#37783 Reported by: Frédéric Chapoton Reviewer(s): Matthias Köppe, Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just miscellanous changes about not using
is_ring, replacing someis_fieldbyin Fieldsand having more precise categories in descent algebras
also sorting the imports on the way
📝 Checklist