Skip to content

Implementing the faithful representation of a generic Lie algebra in positive characteristic #37779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 9, 2024
Merged

Implementing the faithful representation of a generic Lie algebra in positive characteristic #37779

merged 4 commits into from
Jun 9, 2024

Conversation

tscrim
Copy link
Collaborator

@tscrim tscrim commented Apr 10, 2024

This is a very large representation in general, but it is known to be faithful.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 10, 2024

lint failure

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 11, 2024 •
edited
Loading

Documentation preview for this PR (built with commit 46d125c; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@tscrim
Copy link
Collaborator Author

tscrim commented May 28, 2024

I've addressed the lint failure.

mkoeppe
mkoeppe reviewed Jun 4, 2024
View reviewed changes
mkoeppe
mkoeppe reviewed Jun 4, 2024
View reviewed changes
@tscrim tscrim force-pushed the lie_algebras/faithful_pos_char branch from 9ab5b48 to 7fa49e5 Compare June 4, 2024 07:14
@tscrim tscrim removed the v: large label Jun 4, 2024
@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 4, 2024

Test failures (missing import?)

@tscrim tscrim force-pushed the lie_algebras/faithful_pos_char branch from 7fa49e5 to 46d125c Compare June 5, 2024 02:16
@tscrim
Copy link
Collaborator Author

tscrim commented Jun 5, 2024

This was working for me. In the last beta version, the import was removed. Updated and fixed.

mkoeppe
mkoeppe approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Test failure is unrelated.

@tscrim
Copy link
Collaborator Author

tscrim commented Jun 5, 2024

Thank you!

@vbraun vbraun merged commit 4d8d254 into sagemath:develop Jun 9, 2024
@tscrim tscrim deleted the lie_algebras/faithful_pos_char branch June 9, 2024 23:18
@tscrim tscrim removed the v: moderate label Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mkoeppe mkoeppe mkoeppe approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: algebra t: enhancement
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
3 participants
@tscrim @mkoeppe @vbraun