some C4 fixes in combinat folder #37771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoeppe
reviewed
Apr 9, 2024
mkoeppe
reviewed
Apr 9, 2024
mkoeppe
reviewed
Apr 9, 2024
mkoeppe
reviewed
Apr 10, 2024
mkoeppe
reviewed
Apr 10, 2024
mkoeppe
reviewed
Apr 10, 2024
src/sage/combinat/words/morphism.py
Outdated
Comment on lines
1738
to
1741
| try: | ||
| k = self.images()[0].length() | ||
| except IndexError: | ||
| return False |
There was a problem hiding this comment.
Do we consider these 4 lines an improvement over the 1 line that was there before?
Taking into account my comment above, I would just suggest:
if k is None:
return len(set(w.length() for w in self.images())) <= 1
There was a problem hiding this comment.
This avoids to compute all of them in case of failure (similar to all and any).
mkoeppe
reviewed
Apr 10, 2024
Comment on lines
1738
to
+1743
| if k is None: | ||
| return len(set(w.length() for w in self.images())) == 1 | ||
| else: | ||
| return all(w.length() == k for w in self.images()) | ||
| try: | ||
| k = self.images()[0].length() | ||
| except IndexError: | ||
| return True | ||
| return all(w.length() == k for w in self.images()) |
There was a problem hiding this comment.
How about rewriting it using an iterator? Just bikeshedding, feel free to ignore.
images = iter(self.images())
if k is None:
try:
k = next(images).length()
except StopIteration:
return True
return all(w.length() == k for w in images)
There was a problem hiding this comment.
well, this is a list, so there is no point, I think
mkoeppe
approved these changes
Apr 10, 2024
|
Documentation preview for this PR (built with commit b9ae35b; changes) is ready! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just fixing a few of the
ruff --select=C4suggestions in thecombinatfolder📝 Checklist