clean suffix tries #37746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

vbraun merged 4 commits into sagemath:develop from fchapoton:cleanup_suffix_trie

Apr 12, 2024

Contributor

fchapoton commented Apr 4, 2024

some cleanup in the modified file

📝 Checklist

The title is concise and informative.
The description explains in detail what this PR is about.
I have linked a relevant issue or discussion.
I have created tests covering the changes.
I have updated the documentation accordingly.


          clean suffix tries

fchapoton added the c: combinatorics label

Contributor

grhkm21 commented Apr 6, 2024

Can you use f-strings for L1658? Also a few

``self.mname()``

can be replaced by :method:`mname` or something, e.g. L905. Thanks :)

fchapoton added 2 commits

April 9, 2024 08:39


          Merge branch 'develop' into cleanup_suffix_trie

1ceb4b5


          a few suggested details

25593e7

Contributor Author

fchapoton commented Apr 9, 2024

done, thanks for the suggestions

fchapoton added the s: needs review label

mkoeppe reviewed

View reviewed changes

src/sage/combinat/words/suffix_trees.py Outdated Show resolved Hide resolved

mkoeppe reviewed

View reviewed changes

src/sage/combinat/words/suffix_trees.py Outdated Show resolved Hide resolved

mkoeppe reviewed

View reviewed changes

src/sage/combinat/words/suffix_trees.py Outdated Show resolved Hide resolved

mkoeppe reviewed

View reviewed changes

src/sage/combinat/words/suffix_trees.py Outdated Show resolved Hide resolved

mkoeppe reviewed

View reviewed changes

src/sage/combinat/words/suffix_trees.py Outdated Show resolved Hide resolved

mkoeppe reviewed

View reviewed changes

src/sage/combinat/words/suffix_trees.py Outdated Show resolved Hide resolved

mkoeppe reviewed

View reviewed changes

src/sage/combinat/words/suffix_trees.py Outdated Show resolved Hide resolved

mkoeppe reviewed

View reviewed changes

src/sage/combinat/words/suffix_trees.py Outdated Show resolved Hide resolved


          fix suggestions

c693fcd

github-actions bot commented Apr 10, 2024

Documentation preview for this PR (built with commit c693fcd; changes) is ready! 🎉

mkoeppe approved these changes

View reviewed changes

Contributor

mkoeppe left a comment

LGTM.

vbraun merged commit 15ae25f into sagemath:develop

github-actions bot removed the s: positive review label

fchapoton deleted the cleanup_suffix_trie branch

April 13, 2024 06:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: combinatorics