Enhance documentation of Drinfeld module Potemine j-invariants #37630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In DrinfeldModule.j_invariant docstring, there was a typo in the first `.. MATH::` environment: the exponent on the denominator was $d_q$ instead of $d_r$.
We believe there was an ambiguity between our naming of j-invariants, basic j-invariants and jk-invariants, as we follow Potemine's convention, which differs from Papikian's. Consequently, we remove the ambiguity in a note in the docstring.
|
I have trouble building the doc on my machine. I am waiting for the doc to build here to check that the result is properly rendered, before removing the Draft status. |
|
This PR is a good idea in order to clear any potential confusion that might happen for those following Papikian's book. Thanks! I will review it once the doc are finished building. |
|
The result looks good to me! |
j-invariants
j-invariants|
Documentation preview for this PR (built with commit 77314e0; changes) is ready! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The definition of$j$ -invariants, basic $j$ -invariants and $j_k$ -invariants defer in Potemine's article and Papikian's book. Thanks to @DavidAyotte, we follow Potemine's convention. Seeing however the growing popularity of Papikian's book, I reckon it is a good idea to add a note in the documentation addressing those differences.
Also, I fixed a typo.
Potemine:
Papikian:
📝 Checklist
⌛ Dependencies