Implement the solvable and nil radicals of a finite dimensional Lie algebra #37697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83973fd to
36b29b9
Compare
mkoeppe
reviewed
Apr 3, 2024
|
Test failures in |
d92aa8c to
005a6c5
Compare
|
Documentation preview for this PR (built with commit abf746e; changes) is ready! 🎉 |
005a6c5 to
8be290b
Compare
mkoeppe
reviewed
May 11, 2024
| """ | ||
| if sparse: | ||
| return self.value.sparse_vector() | ||
| return self.value | ||
|
|
||
| cpdef to_vector(self, bint sparse=False, order=None): |
There was a problem hiding this comment.
why can it just ignore the order parameter?
(Of course I see that the original code did the same.)
There was a problem hiding this comment.
Because the implementation is based on a fixed order and it is added for (signature) compatibility with the generic implementation.
mkoeppe
reviewed
May 11, 2024
| (b, c, d) | ||
|
|
||
| sage: SL = L.subalgebra([a,b,c,d]); SL | ||
| Subalgebra generated by (a, b, c, d) of Lie algebra on 5 generators (a, b, c, d, e) over Rational Field |
There was a problem hiding this comment.
Suggested change
| Subalgebra generated by (a, b, c, d) of Lie algebra on 5 generators (a, b, c, d, e) over Rational Field | |
| Subalgebra generated by (a, b, c, d) of | |
| Lie algebra on 5 generators (a, b, c, d, e) over Rational Field |
There was a problem hiding this comment.
throughout I recommend to break long output at column 88 so that it fits in the formatted HTML doc
There was a problem hiding this comment.
I did this everywhere I felt it was at most a net-zero improvement in readability.
mkoeppe
reviewed
May 11, 2024
8be290b to
abf746e
Compare
|
Thank you! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 5, 2024
sagemathgh-37697: Implement the solvable and nil radicals of a finite dimensional Lie algebra <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> We implement the algorithms in de Graaf to compute the solvable and nilradicals of a finite dimensional Lie algebra. To do so, we also make further improvements to how subalgebras and ideals of Lie algebras are constructed and handled. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - sagemath#37693 Uses this in the computation - sagemath#37682 Needs the improvements here URL: sagemath#37697 Reported by: Travis Scrimshaw Reviewer(s): Matthias Köppe, Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We implement the algorithms in de Graaf to compute the solvable and nilradicals of a finite dimensional Lie algebra. To do so, we also make further improvements to how subalgebras and ideals of Lie algebras are constructed and handled.
📝 Checklist
⌛ Dependencies