Quaternion Ideal Pushforwards and Pullbacks #37681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tscrim
requested changes
Mar 28, 2024
There was a problem hiding this comment.
@yyyyx4 @saraedum @jhpalmieri @GiacomoPope cc-ing some people who might have other comments on this (from looking at git blame).
|
Documentation preview for this PR (built with commit 3708710; changes) is ready! 🎉 |
S17A05
reviewed
Apr 5, 2024
f139b98 to
2648133
Compare
S17A05
reviewed
Apr 27, 2024
tscrim
approved these changes
Apr 28, 2024
2648133 to
3708710
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added to quaternion fractional ideal class (
QuaternionFractionalIdeal_rational), two methods.pushforwardand.pullbackfrom Lemma 2.1.7 of the thesis of Antonin Leroux, whereI1.pushforward(I2)returns the ideal that is the pushforward ofI1throughI2andI1.pullback(I2)returns the ideal that isI1pulled back throughI2.The optional parameter
sideindicates whether they should be treated as left or right ideals. In the default caseside=None, and it is interpreted as the side which makes sense depending on the shared left/right orders.For now this only works for integral ideals where
I1andI2have coprime norms, but perhaps there is a sensible way to define these concepts for other cases.