Skip to content

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Mar 24, 2024

These upgrades are for

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@tornaria
Copy link
Contributor

LGTM, but I only tested it on my sagemath package for void linux void-linux/void-packages#49527

OTOH, the CI is failing all over the place...

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 25, 2024

the CI is failing all over the place...

Yes, unrelated.

Help in reviewing CI PRs such as #37351 would be appreciated.

Copy link

github-actions bot commented Apr 1, 2024

Documentation preview for this PR (built with commit 14df137; changes) is ready! 🎉

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 7, 2024

LGTM, but I only tested it on my sagemath package

I'll take this and #37584 (comment) as positive review

@vbraun vbraun merged commit 7340f95 into sagemath:develop Apr 12, 2024
vbraun pushed a commit to vbraun/sage that referenced this pull request May 5, 2024
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- Depends on sagemath#37583 (merged here)
- Depends on sagemath#37665 (merged here)
- Depends on sagemath#37667 (merged here)
- Depends on cython/cython@4e9f7307312881111b6
f56279a83812a2309cd16 (see
cython/cython#6087 (comment))
(carried here as a patch)
- Depends on sagemath#37646 (merged here for convenience)

URL: sagemath#37584
Reported by: Matthias Köppe
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request May 9, 2024
sagemathgh-37584: build/pkgs/cython: Update to 3.0.10
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- Depends on sagemath#37583 (merged here)
- Depends on sagemath#37665 (merged here)
- Depends on sagemath#37667 (merged here)
- Depends on cython/cython@4e9f7307312881111b6
f56279a83812a2309cd16 (see
cython/cython#6087 (comment))
(carried here as a patch)
- Depends on sagemath#37646 (merged here for convenience)
    
URL: sagemath#37584
Reported by: Matthias Köppe
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request May 11, 2024
sagemathgh-37584: build/pkgs/cython: Update to 3.0.10
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- Depends on sagemath#37583 (merged here)
- Depends on sagemath#37665 (merged here)
- Depends on sagemath#37667 (merged here)
- Depends on cython/cython@4e9f7307312881111b6
f56279a83812a2309cd16 (see
cython/cython#6087 (comment))
(carried here as a patch)
- Depends on sagemath#37646 (merged here for convenience)
    
URL: sagemath#37584
Reported by: Matthias Köppe
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request May 12, 2024
sagemathgh-37584: build/pkgs/cython: Update to 3.0.10
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- Depends on sagemath#37583 (merged here)
- Depends on sagemath#37665 (merged here)
- Depends on sagemath#37667 (merged here)
- Depends on cython/cython@4e9f7307312881111b6
f56279a83812a2309cd16 (see
cython/cython#6087 (comment))
(carried here as a patch)
- Depends on sagemath#37646 (merged here for convenience)
    
URL: sagemath#37584
Reported by: Matthias Köppe
Reviewer(s):
vbraun pushed a commit to vbraun/sage that referenced this pull request May 12, 2024
sagemathgh-37584: build/pkgs/cython: Update to 3.0.10
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [ ] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->

- Depends on sagemath#37583 (merged here)
- Depends on sagemath#37665 (merged here)
- Depends on sagemath#37667 (merged here)
- Depends on cython/cython@4e9f7307312881111b6
f56279a83812a2309cd16 (see
cython/cython#6087 (comment))
(carried here as a patch)
- Depends on sagemath#37646 (merged here for convenience)
    
URL: sagemath#37584
Reported by: Matthias Köppe
Reviewer(s):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants