Skip to content

CombinatorialFreeModule: Deprecate element construction from a given index #37523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 17 commits into
base: develop
Choose a base branch
from
Draft

CombinatorialFreeModule: Deprecate element construction from a given index #37523

wants to merge 17 commits into from

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Mar 2, 2024 •
edited
Loading

Fixes #34507

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@fchapoton fchapoton mentioned this pull request Mar 6, 2024
Merged
5 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 17, 2024 •
edited
Loading

Documentation preview for this PR (built with commit cc22dac; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Matthias Koeppe and others added 17 commits August 4, 2024 19:23
@mkoeppe
CombinatorialFreeModule._element_constructor_: Deprecate construction…
c405672 
… from basis index
@mkoeppe
src/sage/combinat/free_module.py: Update doctests
75674ec
@mkoeppe
Remove uses of deprecated element construction from index in tests
38b6bfd
@mkoeppe
CubicHeckeAlgebra._markov_trace_coeffs: Remove use of deprecated elem…
a8b0dcf 
…ent construction from index
@mkoeppe
src/sage/algebras/down_up_algebra.py: Fix up doctest
09185bc
@mkoeppe
src/sage/algebras/shuffle_algebra.py (DualPBWBasis._element_construct…
0edd099 
…or_): Use .monomial() explicitly
@mkoeppe
src/sage/algebras/orlik_terao.py (OrlikTeraoInvariantAlgebra._basis_a…
e77f508 
…ction): Use .monomial() explicitly
@mkoeppe
src/sage/algebras/down_up_algebra.py: Fix up doctest (again)
97809d6
@mkoeppe
src/sage/homology/homology_vector_space_with_basis.py (CohomologyRing…
0ecaf56 
….product_on_basis): Remove use of deprecated element construction from index
@mkoeppe
src/sage/categories: Remove use of deprecated element construction fr…
f383f27 
…om index in doctests
@fchapoton
fix doctest in finite_dimensional_algebras_with_basis.py
e1a2d89 
using Permutation
@fchapoton
Update finite_dimensional_algebras_with_basis.py
44b3dba 
another similar fix: Partition -> Permutation
@fchapoton
Update group_algebras.py
ff59cd9 
similar fixes
@mkoeppe
src/sage/categories/bialgebras.py: Remove use of deprecated element c…
e8d5830 
…onstruction from a given index in doctest
@mkoeppe
src/sage/homology/homology_vector_space_with_basis.py (CohomologyRing…
462279d 
…_mod2.Sq): Remove use of deprecated element construction from a given index
@mkoeppe
src/sage/categories/magmas.py: Update doctests
dc89ffe
@mkoeppe
src/sage/categories/modules_with_basis.py: Update doctests
cc22dac
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mkoeppe mkoeppe

Labels
c: combinatorics c: linear algebra v: small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CombinatorialFreeModule._element_constructor_: Deprecate initialization from a given index
2 participants
@mkoeppe @fchapoton