Skip to content

Add mypy.ini #37522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2024
Merged

Add mypy.ini #37522

merged 1 commit into from
Mar 31, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Mar 2, 2024 •
edited
Loading

Configuration from #36198 (comment) @fchapoton @jhpalmieri

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 2, 2024

Documentation preview for this PR (built with commit 8b81855; changes) is ready! 🎉

@jhpalmieri
Copy link
Member

Do we need to specify python_version?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 4, 2024

No idea, I don't use this tool

@jhpalmieri
Copy link
Member

Frédéric, comments?

@fchapoton
Copy link
Contributor

  • This may be slightly prematurate, as typing annotations are very sparse currently in sage, and nowhere ready for full automatic check.

  • I think one should maybe put here the oldest python version that sage currently supports.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 5, 2024

  • This may be slightly prematurate, as typing annotations are very sparse currently in sage, and nowhere ready for full automatic check.

Well, adding the ini file does not set it up to be checked automatically.

fchapoton
fchapoton approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, well

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 6, 2024

Thanks

@vbraun vbraun merged commit e794b9b into sagemath:develop Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fchapoton fchapoton fchapoton approved these changes

Assignees

@mkoeppe mkoeppe

Labels
c: scripts
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
4 participants
@mkoeppe @jhpalmieri @fchapoton @vbraun