Skip to content

ruff PERF fixes in algebras/ #37591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 31, 2024
Merged

ruff PERF fixes in algebras/ #37591

merged 3 commits into from
Mar 31, 2024

Conversation

fchapoton
Copy link
Contributor

a few changes about using more list comprehensions in algebras

plus some pep8, and code details

Note: the classical_lie_algebras file has very slow doctest for E7.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

GiacomoPope
GiacomoPope reviewed Mar 11, 2024
View reviewed changes
GiacomoPope
GiacomoPope reviewed Mar 11, 2024
View reviewed changes
tscrim
tscrim reviewed Mar 16, 2024
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up some of my old code.

Unfortunately that $E_7$ test is the shortest test for that type of implementation, so I feel it should be run as part of the "fast" tests. I plan to make that faster, but I haven't found the time to do so yet...

tscrim
tscrim approved these changes Mar 17, 2024
View reviewed changes
Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM.

@github-actions GitHub Actions
Copy link

Documentation preview for this PR (built with commit 26f7a0e; changes) is ready! 🎉

@vbraun vbraun merged commit 725b635 into sagemath:develop Mar 31, 2024
@fchapoton fchapoton deleted the ruff_perf_algebras branch April 1, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim approved these changes

+1 more reviewer

@GiacomoPope GiacomoPope GiacomoPope left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
c: algebra
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
5 participants
@fchapoton @tscrim @GiacomoPope @vbraun @mkoeppe