Skip to content

build/pkgs/{gdb,gmp,libgd,python3,symmetrica}: Reduce xz to order-only dep #37582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2024
Merged

build/pkgs/{gdb,gmp,libgd,python3,symmetrica}: Reduce xz to order-only dep #37582

merged 1 commit into from
Apr 27, 2024

Conversation

mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Mar 10, 2024 •
edited
Loading

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024 •
edited
Loading

Documentation preview for this PR (built with commit bf7beab; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@kwankyu
Copy link
Collaborator

kwankyu commented Apr 18, 2024

What is the motivation? Why change now?

Actually I wonder why xz was not an order-only dependency in the first place.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 18, 2024

It's unrelated to the xz backdoor!

I think I may have gotten here because @culler reported some strange behavior of the build system to me a while ago.

@kwankyu
Copy link
Collaborator

kwankyu commented Apr 18, 2024

OK. Would you rebase? I want to see this pass B&T at least.

kwankyu
kwankyu approved these changes Apr 18, 2024
View reviewed changes
Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 18, 2024

Thanks!

vbraun pushed a commit to vbraun/sage that referenced this pull request Apr 20, 2024
ceaead0 
sagemathgh-37582: build/pkgs/{gdb,gmp,libgd,python3,symmetrica}: Reduce xz to order-only dep
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->



### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37582
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
@vbraun vbraun merged commit 564a696 into sagemath:develop Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwankyu kwankyu kwankyu approved these changes

Assignees

@mkoeppe mkoeppe

Labels
c: build c: packages: standard
Projects
None yet
Milestone
sage-10.4
Development

Successfully merging this pull request may close these issues.
3 participants
@mkoeppe @kwankyu @vbraun